Add option to allow only overwriting development releases #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! Just FYI I'm extremely busy right now w/work and a few things that have come up outside of work, so it will be probably a couple of weeks before I can get back to reviewing PRs. I will get to them as soon as possible! |
sparkyb
force-pushed
the
overwrite-dev
branch
2 times, most recently
from
b585151
to
b5dcfd8
Compare
With --overwrite-dev the server will only allow overwriting packages whose version has a .devN component.
sparkyb
force-pushed
the
overwrite-dev
branch
from
b5dcfd8
to
fe54fbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the security of not allowing packages with the same version to be overwritten if I forget to bump the version number. However, I'd like to have an automated build job that publishes a development release any time I push to my development branch. Rather than have to remember to edit the version with every commit I push, I want this automated build to automatically add a .dev0 suffix to make sure it is publishing dev releases. I don't want it to have to determine the highest dev version number to increment and I don't mind overwriting these. I could just turn
--overwriteon, but I thought that this was a reasonable use case to have an option that only allowed overwriting of dev releases. So I added a--overwrite-devoption that does that.Internally, it writes to the same config option, so now the option can have 3 possible values: False (no overwrite), True (overwrite any package), "dev" (overwrite only dev releases). I'd be happy to switch it to a real enum if you'd prefer.