use the same mimetypes as pypi does #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for your pull request. I do think the same behaviour can be achieved by calling mimetypes.add_type. Do you have the time to update your patch make core.py register the mimetypes instead? |
|
This has broken my build setup as well. Would love to have this fixed as soon as possible. Thanks for a great tool. |
schmir
added a commit
that referenced
this pull request
Jan 3, 2014
this basically removes the content-encoding header. many thanks to @rmohr for reporting this issue in #42: ,---- | it seems that since pip>=1.5, pip checks the response header of archives | for Content-Encoding. | | This is what pypiserver currently guesses when you try to download a | tar.gz archive: | | ('Content-Type', 'application/x-tar') | ('Content-Encoding', 'gzip') | | What pip now does is decompressing the archive because of the | Content-Encoding, without removing the .gz. Then it tries to untar | it. Because of the filename it tries to decompress the tar archive | again. | | This is what pypi returns: | | $ wget -S https://pypi.python.org/packages/source/p/pytz/pytz-2013.9.tar.gz | [...] | Content-Type: application/x-gzip | Accept-Ranges: bytes | [...] | | The patch below returns the same types as pypi does. `----
|
I've released pypiserver 1.1.4, which contains a workaround for this bug in pip. thanks again @rmmohr. |
|
@schmir, thanks for fixing this so fast, and a much more elegant patch than mine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems that since pip>=1.5, pip checks the response header of archives for Content-Encoding.
This is what pypiserver currently guesses when you try to download a tar.gz archive:
What pip now does is decompressing the archive because of the Content-Encoding, without removing the .gz. Then it tries to untar it. Because of the filename it tries to decompress the tar archive again.
This is what pypi returns:
The patch below returns the same types as pypi does.