Possible to redefine server's welcome-page with cmd-line option (2). #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ankostis
commented
Nov 14, 2014
ankostis
commented
- Extract http welcome-msg(/) in a separate ASCII file.
- Add cmd-line option --welcome for changing the welcome-file and update docs.
- Add 2 TCs, for cmd-line option and / http-req.
|
I think this will break installation as standalone script (see https://pypi.python.org/pypi/pypiserver#alternative-installation-as-standalone-script). I'm not sure how many people - if any - are using that method. The instructions now also point to the wrong URL.. |
|
The welcome msg should NOT be ascii but encoded as UTF-8 to support international users, please... |
ankostis
referenced
this pull request
in ankostis/pypiserver
Jan 13, 2015
ankostis
force-pushed
the
feat/welcome-msg
branch
3 times, most recently
from
aeec7f4
to
e9620d9
Compare
- Read welcome-msg in UTF-8. - Add cmd-line option for `welcome-file`. - Add TCs for welcome-file option and `/` http-req. - Update docs for new option. - Failback to in-code welcome-msg if unreadable (ie standalone mode, bad file).
ankostis
force-pushed
the
feat/welcome-msg
branch
from
e9620d9
to
91f635b
Compare
|
I made it consume utf-8 and provide an in-code message if reading failed (for standalone). |
ankostis
added a commit
that referenced
this pull request
Feb 15, 2015
Possible to redefine server's welcome-page with cmd-line option (2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.