Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: PROJ latest failures #1230

Closed
snowman2 opened this issue Jan 15, 2023 · 4 comments · Fixed by #1241
Closed

TST: PROJ latest failures #1230

snowman2 opened this issue Jan 15, 2023 · 4 comments · Fixed by #1241
Labels
proj Bug or issue related to PROJ test Test related issues
Milestone

Comments

@snowman2
Copy link
Member

snowman2 commented Jan 15, 2023

https://github.com/pyproj4/pyproj/actions/runs/3920975747/jobs/6702947871

FAILED test/test_datum.py::test_datum[Proj] - AssertionError: 
Arrays are not almost equal to 2 decimals

Mismatched elements: 2 / 2 (100%)
Max absolute difference: 7.04815317
Max relative difference: 1.8136988e-06
 x: array([1402291.08, 5076289.59])
 y: array([1402288.54, 5076296.64])
FAILED test/test_datum.py::test_datum[CRS] - AssertionError: 
Arrays are not almost equal to 2 decimals

Mismatched elements: 2 / 2 (100%)
Max absolute difference: 7.04815317
Max relative difference: 1.8136988e-06
 x: array([1402291.08, 5076289.59])
 y: array([1402288.54, 5076296.64])
FAILED test/test_transform.py::test_transform_single_point_nad83_to_nad27 - AssertionError: 
Arrays are not almost equal to 3 decimals

Mismatched elements: 2 / 2 (100%)
Max absolute difference: 14.12664483
Max relative difference: 2.47957478e-05
 x: array([ 569706.333, 4268817.68 ])
 y: array([ 569720.46, 4268813.88])
FAILED test/test_transform.py::test_transform_tuple_nad83_to_nad27 - AssertionError: 
Arrays are not almost equal to 3 decimals

Mismatched elements: 3 / 3 (100%)
Max absolute difference: 21.00634178
Max relative difference: 5.97198411e-05
 x: array([567705.072, 351727.113, 728558.917])
 y: array([567719.249, 351748.119, 728568.053])
FAILED test/test_transformer.py::test_repr__conditional - AssertionError: assert '<Unknown Tra...\n- undefined' == '<Concatenate...47.74, 86.46)'
  - <Concatenated Operation Transformer: pipeline>
  - Description: Inverse of NAD83 to WGS 84 (1) + UTM zone 17N
  + <Unknown Transformer: unknown>
  + Description: unavailable until proj_trans is called
    Area of Use:
  + - undefined
  - - name: North America - onshore and offshore: Canada - Alberta; British Columbia; Manitoba; New Brunswick; Newfoundland and Labrador; Northwest Territories; Nova Scotia; Nunavut; Ontario; Prince Edward Island; Quebec; Saskatchewan; Yukon. United States (USA) - Alabama; Alaska (mainland); Arizona; Arkansas; California; Colorado; Connecticut; Delaware; Florida; Georgia; Idaho; Illinois; Indiana; Iowa; Kansas; Kentucky; Louisiana; Maine; Maryland; Massachusetts; Michigan; Minnesota; Mississippi; Missouri; Montana; Nebraska; Nevada; New Hampshire; New Jersey; New Mexico; New York; North Carolina; North Dakota; Ohio; Oklahoma; Oregon; Pennsylvania; Rhode Island; South Carolina; South Dakota; Tennessee; Texas; Utah; Vermont; Virginia; Washington; West Virginia; Wisconsin; Wyoming.
  - - bounds: (-172.54, 23.81, -47.74, 86.46)
@snowman2 snowman2 added proj Bug or issue related to PROJ test Test related issues labels Jan 15, 2023
@snowman2 snowman2 added this to the 3.5.0 milestone Jan 15, 2023
@snowman2
Copy link
Member Author

Possibly related: OSGeo/PROJ#3535

@snowman2
Copy link
Member Author

snowman2 commented Feb 4, 2023

OSGeo/PROJ@d11c9d5

d11c9d57668697904ce95e02a121cd9389ebb2c2 is the first bad commit
commit d11c9d57668697904ce95e02a121cd9389ebb2c2
Author: Even Rouault <even.rouault@spatialys.com>
Date:   Mon Jan 2 21:21:34 2023 +0100

    proj_create_crs_to_crs(): emit a debug message if the best transformation cannot be used / cs2cs: add a --only-best=no switch

 docs/source/apps/cs2cs.rst | 16 +++++++++-------
 src/4D_api.cpp             | 40 ++++++++++++++++++++++++++++++++--------
 src/apps/cs2cs.cpp         | 20 ++++++++++++++++----
 src/ctx.cpp                |  1 +
 src/proj_internal.h        |  1 +
 test/cli/testvarious       | 21 +++++++++++++++++++++
 test/cli/tv_out.dist       | 10 ++++++++++
 7 files changed, 90 insertions(+), 19 deletions(-)

@snowman2
Copy link
Member Author

snowman2 commented Feb 4, 2023

PROJ master (9.2)

echo -111.5 45.25919444444 | ./cs2cs +proj=latlong +datum=WGS84 +to +proj=utm +zone=10 +datum=NAD27
1402291.08	5076289.59 0.00

PROJ 9.1

echo -111.5 45.25919444444 | cs2cs +proj=latlong +datum=WGS84 +to +proj=utm +zone=10 +datum=NAD27
1402288.54	5076296.64 0.00

@snowman2
Copy link
Member Author

snowman2 commented Feb 7, 2023

Only remaining failure:
https://github.com/pyproj4/pyproj/actions/runs/4094135515/jobs/7108832445

test/test_transformer.py::test_repr__conditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proj Bug or issue related to PROJ test Test related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant