Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rev.2.x.x Firmware Drops Duty Cycle to 0 #19

Closed
pyr0ball opened this issue Mar 8, 2019 · 3 comments
Closed

Rev.2.x.x Firmware Drops Duty Cycle to 0 #19

pyr0ball opened this issue Mar 8, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@pyr0ball
Copy link
Owner

pyr0ball commented Mar 8, 2019

Expected behavior: The PWM duty cycle for VComp_Adj and V_Fol_Adj should be at or close to the desired values set in the parameters section

Actual behavior: They both drop to 0 on boot

I expect something with the logic I wrote isn't doing it's job right. Will require review

@Svatevit
Copy link

Svatevit commented Mar 8, 2019

It's "ADJ_COMP + (diffCompL / 4);"

Shouldn't it be more like "ADJ_COMP += (diffCompL / 4);"?

@pyr0ball pyr0ball self-assigned this Mar 8, 2019
@pyr0ball pyr0ball added the bug Something isn't working label Mar 8, 2019
@pyr0ball pyr0ball added this to Backlog in Pyr0-Piezo Z-Probe Sensor via automation Mar 8, 2019
@pyr0ball
Copy link
Owner Author

pyr0ball commented Mar 8, 2019

@Svatevit I'll give that a whirl, thanks!

@pyr0ball
Copy link
Owner Author

pyr0ball commented Mar 8, 2019

Yep that did it!

I'm far to used to bash operators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants