Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firmware Rev.2.x.x, Analog readings being displayed as 1.00 consistently. Not changing with PWM adjustment #20

Closed
pyr0ball opened this issue Mar 8, 2019 · 3 comments
Closed

Firmware Rev.2.x.x, Analog readings being displayed as 1.00 consistently. Not changing with PWM adjustment #20

pyr0ball opened this issue Mar 8, 2019 · 3 comments
Assignees
@pyr0ball
Labels
bug Something isn't working
Projects
Pyr0-Piezo Z-Probe Sensor

Comments

@pyr0ball
Copy link
Owner

pyr0ball commented Mar 8, 2019

After fixing #19 a new issue showed up, which is that the analog reading serial output is only showing 1.00 regardless of the actual output.

Probing shows 3.84v and 4.22v on V_FOLLOW and VComp respectively
@pyr0ball pyr0ball added the bug Something isn't working label Mar 8, 2019
@pyr0ball pyr0ball self-assigned this Mar 8, 2019
@pyr0ball pyr0ball added this to Backlog in Pyr0-Piezo Z-Probe Sensor via automation Mar 8, 2019
@Svatevit
Copy link

Svatevit commented Mar 8, 2019

Try Serial.println(VCompRef,2);

@pyr0ball pyr0ball changed the title Firmware Rev.2.x.x, Analog readings being displayed as 1.00 consistently. Not changing with PWM adjustment Firmware Rev.2.x.x, Analog readings being displayed as 1.00 consistantly. Not changing with PWM adjustment Mar 9, 2019
@pyr0ball pyr0ball changed the title Firmware Rev.2.x.x, Analog readings being displayed as 1.00 consistantly. Not changing with PWM adjustment Firmware Rev.2.x.x, Analog readings being displayed as 1.00 consistently. Not changing with PWM adjustment Mar 9, 2019
@pyr0ball pyr0ball moved this from Backlog to In progress in Pyr0-Piezo Z-Probe Sensor Mar 9, 2019
@pyr0ball pyr0ball mentioned this issue Apr 17, 2019
Closed
pyr0ball added a commit that referenced this issue Apr 22, 2019
@pyr0ball
migrated floats to #define values
5ff215c 
for more efficient compilation, switched float values set in initial config to definitions that are immediately computed into integers, which cut down on flash usage. also removed non-working debug float outputs for VCompRef and vAdjRead as stated in #20
@foodbandlt
Copy link
Contributor

Addressed in #25 if you want to re-enable those debug variables in the future. Each line of Serial.println takes a crazy amount of flash (up to 4% each in some cases) on the ATmega88. Crazy.

@pyr0ball
Copy link
Owner Author

@foodbandlt actually could you take another look at it after the merge? Notepad++ on one of my systems was badly configured and may have overwritten some of the whitespace fixes you did, and I had to manually merge, so I could have accidentally deleted that part

Pyr0-Piezo Z-Probe Sensor automation moved this from In progress to Done Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pyr0ball pyr0ball

Labels
bug Something isn't working
Projects
Pyr0-Piezo Z-Probe Sensor
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@foodbandlt @pyr0ball @Svatevit