-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mark_chat_unread() method #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a convenience method to user_and_chats/chat.py
@ColinTheShark Can you confirm this works without the need of an |
Also, what about marking a chat as read instead? The raw method allows to do that too, but the issue here is the misleading name. |
I haven't explicitly tested against an
You mean a bound method, right? If so, I added that already :)
While |
@@ -754,3 +754,23 @@ def export_invite_link(self): | |||
""" | |||
|
|||
return self._client.export_invite_link(self.id) | |||
|
|||
def mark_chat_unread(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we add a new method we usually name it like app.action_on_type
, when it's a bound method we remove "type" because it's redundant (bad: chat.mark_chat_unread
, good: chat.mark_unread
).
Apply Dans suggested changes
Title says all. Mark a chat as unread.
https://t.me/PyrogramChat/123932