Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[models] Module design suggestion #93

Closed
frgfm opened this issue Jan 27, 2021 · 5 comments
Closed

[models] Module design suggestion #93

frgfm opened this issue Jan 27, 2021 · 5 comments
Assignees
Labels
module: models Related to models type: enhancement New feature or request
Milestone

Comments

@frgfm
Copy link
Member

frgfm commented Jan 27, 2021

Here is a suggestion for the pyrovision.models module's organization:

  • utils.py: shared utility functions
  • XYZ.py: classification architecture definion with pretrained weights
  • detection: folder with the definition of object detection models with pretrained weights
  • segmentation: folder with the definition of segmentation models with pretrained weights

All performances of pretrained versions should be reported either in the documentation, the readme or a readme in the references folder.

@frgfm frgfm added type: enhancement New feature or request module: models Related to models labels Jan 27, 2021
@frgfm frgfm added this to the 0.1.1 milestone Jan 27, 2021
@frgfm frgfm self-assigned this Jan 27, 2021
@frgfm frgfm changed the title [models] Module design [models] Module design suggestion Jan 27, 2021
@MateoLostanlen
Copy link
Member

I don't understand your point here, we already have this architecture. We only have classification models. You want to add empty detection and segmentation folders?

@frgfm
Copy link
Member Author

frgfm commented Feb 13, 2021

It was to plan the incoming additions to the library

@MateoLostanlen
Copy link
Member

ok sure let's do that

@frgfm frgfm modified the milestones: 0.1.1, 0.1.2 Feb 28, 2021
@frgfm
Copy link
Member Author

frgfm commented Mar 10, 2021

My bad, I haven't cleaned up the classification models! I'll do this by the end of the weekend

@frgfm frgfm modified the milestones: 0.1.2, 0.2.0 Jul 4, 2022
@frgfm
Copy link
Member Author

frgfm commented Jul 17, 2022

Closed by #138 & #150

@frgfm frgfm closed this as completed Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models Related to models type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants