-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add javaspy coloring for flamegraphs #1148
Conversation
size-limit report 📦
|
Hmm can you add the test cases you used here? |
Codecov Report
@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
+ Coverage 70.58% 70.60% +0.02%
==========================================
Files 98 98
Lines 3144 3146 +2
Branches 801 802 +1
==========================================
+ Hits 2219 2221 +2
Misses 921 921
Partials 4 4
Continue to review full report at Codecov.
|
For Packages usually start with reversed domain name ( Maybe something like this |
@@ -93,6 +93,8 @@ function spyToRegex(spyName: string) { | |||
return /^(?<packageName>(.*\/)*)(?<filename>.*\.rb+)(?<line_info>.*)$/; | |||
case 'nodespy': | |||
return /^(\.\/node_modules\/)?(?<packageName>[^/]*)(?<filename>.*\.?(jsx?|tsx?)?):(?<functionName>.*):(?<line_info>.*)$/; | |||
case 'javaspy': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petethepig is this correct (and does the client send this already or do we need to make a change somewhere)
Adds coloring for java:
https://flamegraph.com/share/8022667e-e6d7-11ec-925c-fab0c2c9d0a0
Tested with:
https://regex101.com/r/W5U0uD/2
cc @korniltsev @petethepig