Feat/highlight search on table click #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SLint rules would not allow onClick on a <td>.
…utton default style to mantain same styling.
…dle a click on a table item.
…e-highlight-on-click
…e-highlight-on-click
…at the list item is clickable
size-limit report 📦
|
ScreenshotsThroughput
Disk Usage
Memory
Upload Errors (Total)
Successful Uploads (Total)
CPU Utilization
Result
Details
|
Codecov Report
@@ Coverage Diff @@
## main #701 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 59 59
Lines 2037 2037
Branches 366 366
=======================================
Hits 1570 1570
Misses 439 439
Partials 28 28
Continue to review full report at Codecov.
|
|
This is awesome @eh-am thanks for picking this up and thanks to @gabrielzezze for getting it started! I think we should merge this as is, but considering creating a new
|
|
/create-server |
|
@Rperry2174 Yeah I think so. There are certain table border shenanigans which make it not so straightforward to deal with |
juliosaraiva
pushed a commit
to juliosaraiva/pyroscope
that referenced
this pull request
Jan 16, 2022
* feat(frontend): clicking on table populates search highlight Co-authored-by: Gabriel Zezze <gabrielfz@al.insper.edu.br> Co-authored-by: gabrielzezze <gabriel@zezze.dev>
korniltsev
pushed a commit
that referenced
this pull request
Jul 18, 2023
This PR adds a store-gateway component similar to what exists in Mimir. https://github.com/grafana/mimir/blob/main/pkg/storegateway/gateway.go This is still very early, so far I've decided to depends on Mimir to benefits from the shuffle sharding and replication strategy. I'm not planning to provide any block persistence for now only in-memory. In the future we should use memcached for symbols and tsdb index. The store gateway open block for each tenant within 24h - (now -2h). Since we don't have a compactor a single gateway can download data duplicated by the replication factor of ingesters. This means we need to deduplicate blocks data while streaming now. To speed this up I've implemented a BufferedIterator that helps merging multiple iterator in parallel. In the future we should probably only download compacted blocks. For now we always deduplicate even in the ingester code even though no duplication happens there, the PR was big enough and I don't think it's a big concern right now. The store-gateway also replicate data for high availability which means more duplicates are sent to queriers. We should consider sending block ULID and request querier to select the one to consider. To keep thing simple for the query path right now, we split the queries using the queryStoreAfter configuration. Ultimately if we dedupe by blocks we should be able to remove that configuration and select blocks that needs to be querier from the querier directly. --------- Co-authored-by: Christian Simon <simon@swine.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #556
Closes #500
A video demonstrating how it works:
https://user-images.githubusercontent.com/6951209/148980139-4eacadc8-ade4-4a49-a0fd-4358bf1d9d9e.mp4
It's a bit sluggish due to #702