Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduled sorting/filtering bug on started and stopped views in rtorrent #36

Merged
merged 1 commit into from
Mar 12, 2017

Conversation

chros73
Copy link
Contributor

@chros73 chros73 commented Jul 8, 2016

Fixes: rakshasa/rtorrent#449
Refers to: chros73#19

I've also created a pull request in rtorrent project for this, but who knows what will happen to it. :) We can remove it later if it will be accepted.
rakshasa/rtorrent#451

@pyroscope
Copy link
Owner

I might add this before mainline does, but I hope you DO realize there's an easier way: make 2 new views (they're different anyway), and rebind key 3 + 4 to show those views.

@chros73
Copy link
Contributor Author

chros73 commented Jul 8, 2016

:) Of course, but that doesn't fix this critical bug in the client itself.

@chros73
Copy link
Contributor Author

chros73 commented Jul 8, 2016

Note: under "all" in the patch name I understand version >= 0.9.2 (as the current build script works). I don't know how this patch behaves with versions before this (I haven't checked).

@pyroscope
Copy link
Owner

I removed pre-092 a while ago anyway, I think. If anyone wants the stoneage, they can check out old revisions.

@pyroscope pyroscope merged commit ff4b784 into pyroscope:master Mar 12, 2017
@chros73 chros73 deleted the fix_filtering_started_stopped branch May 15, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants