Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: scrolling Frame does not account for extended Dropdown #36

Closed
luiz00martins opened this issue Oct 22, 2022 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@luiz00martins
Copy link

Note: I'm not sure if this is a bug report or a feature request (i.e. if this is unintended or intended behaviour).


Describe the bug

An expanded Dropdown may have items inaccessible, as Frame scrolling is disabled while the dropdown is expanded.

Minimal Working Example

clip.dropwown.inaccessible.mp4
local filePath = "/basalt.lua"
if not(fs.exists(filePath))then
    shell.run("pastebin run ESs1mg7P packed true "..filePath:gsub(".lua", ""))
end
local basalt = require(filePath:gsub(".lua", ""))

local main = basalt.createFrame("mainFrame"):setScrollable()

local w, h = term.getSize()

for i=1,5 do
	main:addDropdown('dropdown_'..tostring(i))
		:setPosition(2, h+i-2)
		:setSize(10, 1)
		:addItem('Item 1')
		:addItem('Item 2')
		:addItem('Item 3')
		:show()
end

basalt.autoUpdate()

In the example above, Item 2 and Item 3 are inaccessible, as:

  1. They are not visible even in that maximum scroll down of the Frame
  2. Further scrolling is disabled while the Dropdown is expanded

Expected behavior

Be able to scroll further down the Frame while the Dropdown is expanded.

Checklist

[x] I am running the latest version.

@luiz00martins luiz00martins added the bug Something isn't working label Oct 22, 2022
@NoryiE
Copy link
Collaborator

NoryiE commented Oct 22, 2022

Hello, i guess this is the fix you want: b303b46
currently only on the dev branch available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants