Reconcile errors "prometheus rule not found"

[ArthurSens]

Quite often (read 100% of the time) when we create a new SLO, Pyrra sends error logs and increments the metric controller_runtime_reconcile_total{result="error"}, which consequentially triggers our SLO about Pyrra reconciliations 😅

Error logs

2023-11-27T11:57:48Z ERROR Reconciler error {"controller": "servicelevelobjective", "controllerGroup": "pyrra.dev", "controllerKind": "ServiceLevelObjective", "ServiceLevelObjective": {"name":"observability-thanos-stack-thanos-query-latency","namespace":"observability"}, "namespace": "observability", "name": "observability-thanos-stack-thanos-query-latency", "reconcileID": "3d51a06b-674b-4701-be57-9d0ac0cc1864", "error": "failed to create prometheus rule: PrometheusRule.monitoring.coreos.com \"observability-thanos-stack-thanos-query-latency\" not found"}

Ideally, Pyrra would not send error logs or increment error metrics when PrometheusRules aren't found, and would just create them as expected :)

Pyrra version: 0.7.1

[9SMTM6]

has this been released? in that case perhaps this can be closed.

[metalmatze]

Yes, it was part of v0.7.2 and all later patch releases.