Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to spreg tests for travis #629

Closed
wants to merge 1 commit into from

Conversation

dfolch
Copy link
Member

@dfolch dfolch commented Jun 17, 2015

This PR is intended to get spreg in line with travis if #628 is accepted. Everything in spreg now passes when I call nosetests --with-coverage --cover-package=pysal --with-doctest on my machine. However, the stuff my machine said needed fixing is slightly different from the spreg errors seen here: https://travis-ci.org/jlaura/pysal/jobs/66811136. I also had to fix some of the unit tests to get this to pass on my machine. I'll be interested to see what travis thinks of these changes.

I talked to @pedrovma, and he will merge these changes to the SVN side in the future.

@sjsrey
Copy link
Member

sjsrey commented Jun 17, 2015

Didn't we agree to only pull from spreg? i'm concerned that we now will have to make changes in two places and this is why we decided spreg in pysal/pysal was off limits. changes go into svn then pysal/pysal from svn?

If it is just to test how these changes would impact travis (which i agree is nice), I think you can set up the testing on your own fork of pysal.

@dfolch
Copy link
Member Author

dfolch commented Jun 17, 2015

According to @pedrovma they have always had trouble getting the tests to pass in both the SVN and git, so that part of the code base has had mismatches. I think that is why he wasn't too concerned about these changes affecting the SVN side. There is nothing substantive here, just some tweaks to the rounding to make travis happy. I'll try to get travis working in my fork.

@dfolch dfolch closed this Jun 17, 2015
@sjsrey
Copy link
Member

sjsrey commented Jun 17, 2015

It probably makes sense to have a small group meet to come up with a concerted standard for handling the tests. This way we are all on the same page.

@pedrovma
Copy link
Member

I'd be up for a short meeting anytime to discuss this. It's been a while since we last discussed how to proceed with these issues. An update would be welcome. This PR was meant as a very specific fix to Travis results only, that's why @dfolch and I thought it would be okay to exceptionally invert the standard procedure. But you're right, just checking a fork also works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants