Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg #925

Closed
wants to merge 11 commits into from
Closed

Reorg #925

wants to merge 11 commits into from

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Mar 28, 2017

Start of Makefile for exploring reorg_dist.

Note that for the modules we are bringing in (only libpysal and esda for exploration at the moment) we have to haul their package folders up one level after cloning. This works but I'm wondering if there are going to be problems induced here?

We could punt on the source redistribution and just rely on pip to install the dependencies (i.e., libpysal, esda, spint.......)? In this case the makefile could be used for setting up a local dev environment, while the dependences remain outside of the pysal/pysal upstream repository? Food for thought.

Also added a setup.py for the metapackage. This would have pip do the heaving lifting on dependencies - pysal becomes a lightweight metapackage.

@sjsrey sjsrey requested a review from ljwolf March 28, 2017 22:31
@ljwolf
Copy link
Member

ljwolf commented Mar 29, 2017

test failures look like an issue in the libpysal API.

@coveralls
Copy link

coveralls commented Apr 8, 2017

Coverage Status

Coverage decreased (-83.06%) to 0.0% when pulling 5b74a7e on sjsrey:reorg into 3fb7073 on pysal:reorg.

@coveralls
Copy link

coveralls commented Apr 9, 2017

Coverage Status

Coverage decreased (-83.06%) to 0.0% when pulling fa0a128 on sjsrey:reorg into 3fb7073 on pysal:reorg.

@coveralls
Copy link

coveralls commented May 19, 2017

Coverage Status

Coverage decreased (-83.06%) to 0.0% when pulling 8e5e1ee on sjsrey:reorg into 3fb7073 on pysal:reorg.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.2%) to 89.286% when pulling 3adaa70 on sjsrey:reorg into 3fb7073 on pysal:reorg.

@sjsrey sjsrey closed this Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants