Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis CI for new testing schema #308

Merged
merged 18 commits into from
Sep 1, 2019

Conversation

jGaboardi
Copy link
Member

Attempting to address #299

@jGaboardi
Copy link
Member Author

jGaboardi commented Aug 25, 2019

Travis CI not kicking in, so may have bad syntax in .travis.yml

@coveralls
Copy link

coveralls commented Aug 25, 2019

Pull Request Test Coverage Report for Build 1734

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.854%

Totals Coverage Status
Change from base Build 1733: 0.0%
Covered Lines: 1354
Relevant Lines: 1368

💛 - Coveralls

@jGaboardi
Copy link
Member Author

jGaboardi commented Aug 25, 2019

In this PR I have attempted to implement both the alternative testing structure advised by @ocefpaf while maintaining the legacy allow_failures options used when testing against the bleeding edge libpysal (PYSAL_PYPI=false) and when testing with the requirements_plus.txt soft dependencies (PYSAL_PLUS=true). Due to not being able to have named jobs through matrix expansion, it appears that all combinations must be enumerated with the include function. With this new matrix of tests (12 in total), the tarball type is tested four times. If I understand correctly, the tarball tests are simply checking the distribution (not running any other actual tests) so limiting these to one check would be acceptable. Am I correct in this?

I would appreciate any/all reviews & suggestions.

@jGaboardi jGaboardi changed the title [WIP] Update travis CI for new testing schema Update travis CI for new testing schema Aug 25, 2019
@jGaboardi
Copy link
Member Author

@sjsrey Do you have any thoughts on this before merging?

@ocefpaf If you have a moment, would you be able to review this PR?

@jGaboardi jGaboardi merged commit c577c8c into pysal:master Sep 1, 2019
@jGaboardi jGaboardi deleted the update_travis branch September 1, 2019 20:24
@ocefpaf
Copy link

ocefpaf commented Sep 2, 2019

@ocefpaf If you have a moment, would you be able to review this PR?

Sorry, I was away the past two weeks. LGMT!

PS: we should probably abstract most of that into a ci-helper so people can easily copy-n-paste it into new projects.

@jGaboardi
Copy link
Member Author

@ocefpaf Thanks!

PS: we should probably abstract most of that into a ci-helper so people can easily copy-n-paste it into new projects.

For example?

@ocefpaf
Copy link

ocefpaf commented Sep 2, 2019

For example?

Something like https://github.com/astropy/ci-helpers. I'll try to put something together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants