Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more py2 #1142

Merged
merged 7 commits into from
Oct 29, 2022
Merged

No more py2 #1142

merged 7 commits into from
Oct 29, 2022

Conversation

AndreasHeger
Copy link
Contributor

Remove py2 support from pysam.

@jmarshall
Copy link
Member

That macOS error: liblzma development files not found build failure is something I've been meaning to look into for a long while for both htslib and pysam: recent macOS releases no longer include the same subset of lzma development files as previous releases. For some reason some dependencies that come along with previous Pythons paste over the cracks enough. For now, perhaps just leave Python 3.11 off…?

@AndreasHeger AndreasHeger marked this pull request as ready for review October 29, 2022 21:02
@AndreasHeger AndreasHeger merged commit cb34439 into master Oct 29, 2022
@mdshw5
Copy link

mdshw5 commented Dec 6, 2022

@jmarshall I'm seeing the liblzma error message on macOS with both python 3.10 and python 3.9 as well. Do you have any idea about the best way to install pysam on the GitHub Actions macos-latest images?

@jmarshall
Copy link
Member

Make sure you have your own full liblzma installation as well as the system's partial one, e.g. via brew install xz.

@mdshw5
Copy link

mdshw5 commented Dec 6, 2022

Thanks @jmarshall - that was my first thought, but the issue persists (even with brew reinstall xz): https://github.com/mdshw5/pyfaidx/actions/runs/3631904338/jobs/6127118303#step:3:1. It's not blocking me from releasing new packages as I only test against pysam, but it would still be nice to get macOS tests passing.

@jmarshall
Copy link
Member

That appears to have failed installing Python prerequisites, rather than building pysam itself. But I can't click through to the details on my phone 😄

(Unfortunately I'm travelling at the moment and won't be able to look at this in depth for at least a couple of weeks.)

@mdshw5
Copy link

mdshw5 commented Dec 6, 2022

No worries @jmarshall - I'll leave it off here, and will only tag you further if I identify a solution. Enjoy your travels!

@AndreasHeger AndreasHeger deleted the no-more-py2 branch March 27, 2023 20:44
@jmarshall
Copy link
Member

@mdshw5: I'm finally back looking into this problem, and of course by now your logs have expired. Do you have any more recent builds failing due to this or any other further information? No problem if not, I can do some test runs to try to reproduce the problem…

@jmarshall
Copy link
Member

@mdshw5: Now fixed by PR #1207. It turns out that for multiarch macOS builds (I suspect your builds were during a period in which the Pythons 3.9 and 3.10 you used were also multiarch), you need to make sure that it doesn't find a brewed xz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants