Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote list break fix #71

Merged
merged 22 commits into from
Jul 8, 2022
Merged

Remote list break fix #71

merged 22 commits into from
Jul 8, 2022

Conversation

rstoneback
Copy link
Collaborator

@rstoneback rstoneback commented May 26, 2022

Description

Addresses #70

Fixes use of remote_file_list for GNSS TEC vtec

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality or documentation)

How Has This Been Tested?

  • Added unit tests for new function errors
  • Ran unit tests that originally identified remote_file_list issue. Works now.

Test Configuration

  • Operating system: MacOS
  • Version number: Python 3.9
  • Any details about your local setup that are relevant

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have linted the files updated in this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@rstoneback rstoneback linked an issue May 26, 2022 that may be closed by this pull request
@rstoneback rstoneback mentioned this pull request May 26, 2022
18 tasks
@rstoneback rstoneback requested a review from aburrell May 27, 2022 22:46
@rstoneback rstoneback requested a review from aburrell June 10, 2022 15:17
pysatMadrigal/instruments/gnss_tec.py Outdated Show resolved Hide resolved
pysatMadrigal/instruments/gnss_tec.py Outdated Show resolved Hide resolved
pysatMadrigal/instruments/gnss_tec.py Show resolved Hide resolved
pysatMadrigal/instruments/methods/general.py Outdated Show resolved Hide resolved
pysatMadrigal/instruments/methods/general.py Outdated Show resolved Hide resolved
pysatMadrigal/instruments/methods/general.py Outdated Show resolved Hide resolved
rstoneback and others added 2 commits June 28, 2022 17:45
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Copy link
Collaborator Author

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I had comments placed in a 'pending' mode and current UI indicates I need to hit 'Comment' on this review to make em real.

pysatMadrigal/instruments/gnss_tec.py Outdated Show resolved Hide resolved
pysatMadrigal/instruments/methods/general.py Outdated Show resolved Hide resolved
@rstoneback rstoneback requested a review from aburrell July 6, 2022 19:35
@aburrell aburrell added this to the 0.1.0 Release milestone Jul 6, 2022
@rstoneback rstoneback requested a review from aburrell July 8, 2022 15:38
@rstoneback rstoneback merged commit ab64d7c into develop Jul 8, 2022
@rstoneback rstoneback deleted the remote_list_break_fix branch July 8, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: list_remote_files and two_digit_year_break
2 participants