Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/STY: update platform names #52

Merged
merged 4 commits into from
May 18, 2021
Merged

BUG/STY: update platform names #52

merged 4 commits into from
May 18, 2021

Conversation

jklenzing
Copy link
Member

Description

Addresses #49

With the release of pysat 3.0.0, 'pysat' is reserved for platforms from the core package. Updates platform names to 'missions'.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

Tested by registering the instrument package and importing assuming registration.

import pysat
import pysatMissions
pysat.utils.registry.register_by_module(pysatMissions.instruments)
sgp4 = pysat.Instrument('missions', 'sgp4')

Test Configuration:

  • Mac OS X 10.15.7
  • python 3.8.2
  • pysat 3.0.0

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

@jklenzing jklenzing added this to the 0.3.0 release milestone May 17, 2021
@jklenzing jklenzing linked an issue May 17, 2021 that may be closed by this pull request
@jklenzing jklenzing added the bug Something isn't working label May 17, 2021
@jklenzing jklenzing changed the title Sty/inst rename BUG/STY: update platform names May 17, 2021
@jklenzing jklenzing marked this pull request as ready for review May 17, 2021 21:12
@jklenzing jklenzing requested a review from aburrell May 17, 2021 21:12
@jklenzing jklenzing merged commit ee6fa10 into develop May 18, 2021
@jklenzing jklenzing deleted the sty/inst_rename branch May 18, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Instrument registration does not work
2 participants