Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Instrument registration does not work #49

Closed
jklenzing opened this issue Apr 28, 2021 · 3 comments · Fixed by #52
Closed

BUG: Instrument registration does not work #49

jklenzing opened this issue Apr 28, 2021 · 3 comments · Fixed by #52
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jklenzing
Copy link
Member

Describe the bug
If I try to register the instruments in pysat, the registry is updated accordingly. However, pysat will search in the main package for the instruments rather than loading them from the registry.

To Reproduce

import pysat
import pysatMissions
pysat.utils.registry.register_by_module(pysatMissions.instruments)
sgp4 = pysat.Instrument('pysat', 'sgp4')

produces

ModuleNotFoundError: No module named 'pysat.instruments.pysat_sgp4'

Presumably this is because the platform name is pysat.

Expected behavior
Should load from pysatMissions.

Additional context
This could be solved here by renaming the platform or in the main package by adjusting how the code works. Tagging @rstoneback.

@jklenzing jklenzing added this to the 0.3.0 release milestone Apr 28, 2021
@jklenzing jklenzing added the bug Something isn't working label Apr 28, 2021
@jklenzing jklenzing mentioned this issue Apr 28, 2021
10 tasks
@rstoneback
Copy link
Collaborator

rstoneback commented Apr 28, 2021 via email

@jklenzing
Copy link
Member Author

jklenzing commented Apr 29, 2021

Possibilities for a new platform:

  • orbprop
  • orbital
  • propagator
  • missions (AGB suggestion)

@jklenzing jklenzing self-assigned this May 10, 2021
@jklenzing jklenzing linked a pull request May 17, 2021 that will close this issue
10 tasks
@jklenzing
Copy link
Member Author

Closing with merge of #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants