Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Direct Input of Keplerian elements, other parameters #61

Closed
jklenzing opened this issue Jun 29, 2021 · 1 comment · Fixed by #60
Closed

ENH: Direct Input of Keplerian elements, other parameters #61

jklenzing opened this issue Jun 29, 2021 · 1 comment · Fixed by #60
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jklenzing
Copy link
Member

jklenzing commented Jun 29, 2021

Is your feature request related to a problem? Please describe.
Newer versions of sgp4 allow for the direct input of Keplerian elements to describe an orbit rather than TLEs (eccentricity, inclination, argument of periapsis, right ascension of the ascending node, mean anomaly, mean motion).

Describe the solution you'd like
It would be easier to allow these as direct inputs to the instrument rather than generate a fake TLE (#8). The new syntax also allows for creating an array of timestamps rather than looping through the code.

Describe alternatives you've considered
From a design perspective, it may be easier for some to envision periapsis and apoapsis altitudes rather than eccentricity and mean motion (inverse of orbital period). Conversion routines should be added, which are either run by the user or directly run by the pysat instrument.

Additional context
preliminary tests of this workflow in #60. May replace #8 and #13

@jklenzing jklenzing added the enhancement New feature or request label Jun 29, 2021
@jklenzing jklenzing linked a pull request Jun 29, 2021 that will close this issue
10 tasks
@jklenzing jklenzing self-assigned this Jun 29, 2021
@jklenzing jklenzing added this to the 0.3.0 release milestone Jun 29, 2021
@jklenzing jklenzing mentioned this issue Aug 5, 2021
10 tasks
@jklenzing
Copy link
Member Author

Closing with merge of #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant