Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odesolve(...verbose=True) hangs under python 3 #164

Closed
jmuhlich opened this issue Sep 29, 2015 · 3 comments
Closed

odesolve(...verbose=True) hangs under python 3 #164

jmuhlich opened this issue Sep 29, 2015 · 3 comments
Labels
Milestone

Comments

@jmuhlich
Copy link
Member

test_integrate.py's test_integrate_with_expression calls odesolve with verbose=True, and it seems like the communication with BNG hangs when waiting for the end of the output. This happens on python 3.4.3 on homebrew on the mac I'm using right now, not sure about other platforms yet. There shouldn't be any verbose=True integrator calls in the test suite, so that's the quick fix to make the tests run to completion, but we do need to figure out what's wrong with the verbose=True code in bng.py under python 3 for general usage.

jmuhlich added a commit to jmuhlich/pysb that referenced this issue Sep 29, 2015
* Remove all verbose=True args to Solver, as verbose mode hangs the Popen
  communication with BNG for some reason under py3. Fixes pysb#164.
* Eliminate direct comparison of Monomer objects in core by comparing their
  ids instead.
* Properly import scipy.integrate in integrate.py rather than rely on an
  unrelated scipy.weave import just coincidentally making it work. Since
  weave doesn't exist under py3, the whole thing fell apart. This change
  necessitated a little refactoring around checking that the user-requested
  integrator module exists. Fixes pysb#163.
jmuhlich added a commit to jmuhlich/pysb that referenced this issue Sep 29, 2015
* Remove all verbose=True args to Solver, as verbose mode hangs the Popen
  communication with BNG for some reason under py3. Fixes pysb#164.
* Eliminate direct comparison of Monomer objects in core by comparing their
  ids instead.
* Properly import scipy.integrate in integrate.py rather than rely on an
  unrelated scipy.weave import just coincidentally making it work. Since
  weave doesn't exist under py3, the whole thing fell apart. This change
  necessitated a little refactoring around checking that the user-requested
  integrator module exists. Fixes pysb#163.
@jmuhlich
Copy link
Member Author

Oops, #167 shouldn't close this. Try to remember to reopen after the PR merge auto-closes it. :)

@jmuhlich jmuhlich added the bug label Sep 30, 2015
@jmuhlich jmuhlich reopened this Oct 1, 2015
alubbock pushed a commit to LoLab-MSM/pysb that referenced this issue Oct 1, 2015
* Remove all verbose=True args to Solver, as verbose mode hangs the Popen
  communication with BNG for some reason under py3. Fixes pysb#164.
* Eliminate direct comparison of Monomer objects in core by comparing their
  ids instead.
* Properly import scipy.integrate in integrate.py rather than rely on an
  unrelated scipy.weave import just coincidentally making it work. Since
  weave doesn't exist under py3, the whole thing fell apart. This change
  necessitated a little refactoring around checking that the user-requested
  integrator module exists. Fixes pysb#163.
@jmuhlich jmuhlich added this to the v1.1 milestone Apr 1, 2016
@alubbock
Copy link
Member

Has this been resolved? Works for me on Python 3.5.2 macOS/homebrew.

@alubbock
Copy link
Member

The full test suite seems to run fine on Python 3.6.4 on macOS for me. There have been a lot of changes to the simulation engine since this issue was filed in September 2015, so I'll presume this has been fixed somewhere along the line. Please reopen if you're still experiencing issues.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants