New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
odesolve(...verbose=True) hangs under python 3 #164
Comments
* Remove all verbose=True args to Solver, as verbose mode hangs the Popen communication with BNG for some reason under py3. Fixes pysb#164. * Eliminate direct comparison of Monomer objects in core by comparing their ids instead. * Properly import scipy.integrate in integrate.py rather than rely on an unrelated scipy.weave import just coincidentally making it work. Since weave doesn't exist under py3, the whole thing fell apart. This change necessitated a little refactoring around checking that the user-requested integrator module exists. Fixes pysb#163.
* Remove all verbose=True args to Solver, as verbose mode hangs the Popen communication with BNG for some reason under py3. Fixes pysb#164. * Eliminate direct comparison of Monomer objects in core by comparing their ids instead. * Properly import scipy.integrate in integrate.py rather than rely on an unrelated scipy.weave import just coincidentally making it work. Since weave doesn't exist under py3, the whole thing fell apart. This change necessitated a little refactoring around checking that the user-requested integrator module exists. Fixes pysb#163.
Oops, #167 shouldn't close this. Try to remember to reopen after the PR merge auto-closes it. :) |
* Remove all verbose=True args to Solver, as verbose mode hangs the Popen communication with BNG for some reason under py3. Fixes pysb#164. * Eliminate direct comparison of Monomer objects in core by comparing their ids instead. * Properly import scipy.integrate in integrate.py rather than rely on an unrelated scipy.weave import just coincidentally making it work. Since weave doesn't exist under py3, the whole thing fell apart. This change necessitated a little refactoring around checking that the user-requested integrator module exists. Fixes pysb#163.
Has this been resolved? Works for me on Python 3.5.2 macOS/homebrew. |
The full test suite seems to run fine on Python 3.6.4 on macOS for me. There have been a lot of changes to the simulation engine since this issue was filed in September 2015, so I'll presume this has been fixed somewhere along the line. Please reopen if you're still experiencing issues. Thanks. |
test_integrate.py's test_integrate_with_expression calls
odesolve
with verbose=True, and it seems like the communication with BNG hangs when waiting for the end of the output. This happens on python 3.4.3 on homebrew on the mac I'm using right now, not sure about other platforms yet. There shouldn't be any verbose=True integrator calls in the test suite, so that's the quick fix to make the tests run to completion, but we do need to figure out what's wrong with the verbose=True code in bng.py under python 3 for general usage.The text was updated successfully, but these errors were encountered: