Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GitHub Actions fail-fast #587

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

jmuhlich
Copy link
Member

@jmuhlich jmuhlich commented Feb 23, 2024

This lets us see all the possible problems across the entire CI matrix rather than cancelling all the jobs as soon as any one fails.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (b053005) to head (d99e2fd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files         106      106           
  Lines       11253    11253           
=======================================
  Hits         8809     8809           
  Misses       2444     2444           
Flag Coverage Δ
os-macos-latest 78.28% <ø> (?)
os-ubuntu-latest 78.28% <ø> (ø)
os-windows-latest 2.77% <ø> (?)
python-3.10 78.28% <ø> (?)
python-3.11 78.28% <ø> (?)
python-3.12 78.28% <ø> (ø)
python-3.8 78.26% <ø> (?)
python-3.9 78.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmuhlich
Copy link
Member Author

I have no idea why Ubuntu / Python3.9 fails at pip install libroadrunner. I tested that same combination locally and it works fine. You can observe that the wheel does exist on pypi.

@FFroehlich
Copy link
Contributor

I have no idea why Ubuntu / Python3.9 fails at pip install libroadrunner. I tested that same combination locally and it works fine. You can observe that the wheel does exist on pypi.

reran tests, looks like the libroadrunner failure was transient.

@jmuhlich jmuhlich merged commit fa9be1a into pysb:master Feb 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants