Docs for release 2023.11.1 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antocuni
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
LGTM but I have a comment:
Removed mini-coi because that's not fixed the header issue (it's the CDN).
are you 100% sure about this? If I understand correctly, the current situation is:
- live examples on docs.pyscript.net don't work because docs.pyscript.net sends a wrong header (not the CDN)
- live examples on https://pyscript.github.io/docs/ works
Are you sure that by removing mini-coi you don't break 2?
| @@ -106,7 +106,7 @@ module in the document's `<head>` tag: | |||
| <meta charset="utf-8" /> | |||
| <meta name="viewport" content="width=device-width,initial-scale=1" /> | |||
| <title>🦜 Polyglot - Piratical PyScript</title> | |||
| <script type="module" src="https://pyscript.net/snapshots/2023.11.1.RC3/core.js"></script> | |||
| <script type="module" src="https://pyscript.net/snapshots/2023.11.1/core.js"></script> | |||
There was a problem hiding this comment.
random comment, but ideally we should have a script which automatically updates all these URLs.
It's only a matter of time before we will forget to update one
There was a problem hiding this comment.
Totally agree... it's on my todo list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated everything to point to 2023.11.1. Removed mini-coi because that's not fixed the header issue (it's the CDN).