Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Minor output bug after selecting video #702

Open
guiltiest-gear opened this issue Sep 18, 2023 · 3 comments
Open

[BUG]: Minor output bug after selecting video #702

guiltiest-gear opened this issue Sep 18, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@guiltiest-gear
Copy link

Describe the bug

After selecting a video to play, a blank line and the literal characters of ${new_line} show up in the output

To Reproduce

  1. Install ytfzf 2.6.1
  2. Enable thumbnails in config or with command line option
  3. Search for a video
  4. Notice how there is a blank like after the scraping message, and the string of ${new_line} appended to Fetching thumbnails...

Expected behavior

There should be no blank like and no extra characters

Screenshots

Screenshot_2023-09-17_18-47-21

Information

  • OS: EndeavourOS
  • Terminal: kitty 0.29.2
  • Ytfzf version: 2.6.1
  • Output of readlink $(which sh): bash
  • (if is a thumbnail issue) run ytfzf --thumbnail-log=log.txt and post the file:

Additional context

This bug doesn't occur in 2.6.0, so it must be from a commit between 2.6.0 and 2.6.1

@guiltiest-gear guiltiest-gear added the bug Something isn't working label Sep 18, 2023
@Euro20179
Copy link
Collaborator

I believe this is fixed in the development branch, you could try using that.

@guiltiest-gear
Copy link
Author

I'll clone to the latest commit and get back to you on that

@guiltiest-gear
Copy link
Author

Newest commit fixes ${new_line} bug, but extra blank line is still present
Screenshot_2023-09-18_14-27-02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants