Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python <= 2.6, 3.0-3.3 #165

Merged
merged 3 commits into from
Nov 13, 2017
Merged

Drop support for EOL Python <= 2.6, 3.0-3.3 #165

merged 3 commits into from
Nov 13, 2017

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 27, 2017

Fixes #159.

@hugovk
Copy link
Member Author

hugovk commented Oct 28, 2017

The Travis CI "runslowtests" job is failing in the same way as master.

I've not compared Appveyor, but I see that's also failing on master.

@hugovk
Copy link
Member Author

hugovk commented Nov 9, 2017

Any thoughts on merging this?

I see #158 added "this library is in maintenance mode and should not be used in new code", and dropping support for EOL Pythons would make that maintenance easier.

@nicoddemus
Copy link
Member

Hi @hugovk sorry for the silence here, thanks for tackling this!

We definitely want to merge this; the next pytest release (3.3) already dropped support for Python 2.6 and 3.3.

Would you mind rebasing/merging with the latest master? #157 fixed all tests in Linux and Windows so we can then merge this with more confidence. Also, I added an xfail in #157 for 2.6 which we could remove in this PR as well.

@hugovk
Copy link
Member Author

hugovk commented Nov 10, 2017

@nicoddemus Rebased, and reverted bdc9112!

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! We will have to see how we plan to release this to avoid breaking existing installations

@nicoddemus
Copy link
Member

nicoddemus commented Nov 10, 2017

Are we to release 1.5.0 or 2.0 given the fact we are dropping 2.6 and 3.3?

We should decide and release pytest-3.2.4 with the appropriate pin, so the next pytest release will allow users to pin appropriately to the pytest version if the need to continue using 2.6 or 3.3. I see two options:

  1. py-1.5 and pytest-3.3: then pytest-3.2.4 (the next bugfix) should pin to py<1.5.
  2. py-2.0 and pytest-4.0: then pytest-3.2.4 (the next bugfix) should pin to py<2.0.

@RonnyPfannschmidt @The-Compiler @flub @hackebrot @hpk42 what do you guys think?

@RonnyPfannschmidt
Copy link
Member

@nicoddemus i beleive a 1.5.0 is fine - but we should make a removal note about it (since those are EOL python version i think its fine to expect due diligence from those not fixing that problem)

@nicoddemus
Copy link
Member

but we should make a removal note about it

Done

@nicoddemus
Copy link
Member

If nobody manifests against it until then, I will open a PR on pytest tomorrow pinning py<1.5, then we can release pytest-3.2.4 with the pin and then finally we can release py-1.5.

@nicoddemus
Copy link
Member

Actually I went ahead and created the PR now: pytest-dev/pytest#2916. We can wait until tomorrow to merge it; if nobody objects, I will merge and get pytest-3.2.4 rolling.

@nicoddemus nicoddemus merged commit e188b67 into pytest-dev:master Nov 13, 2017
@nicoddemus
Copy link
Member

Thanks @hugovk again!

Now we just need to wait for pytest-3.2.4 to go out before releasing py-1.5. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants