Drop support for EOL Python 3.3 #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCManticore
reviewed
Dec 11, 2017
astroid/interpreter/_import/spec.py
Outdated
| @@ -178,7 +178,7 @@ def contribute_to_path(self, spec, processed): | |||
| ImpFinder, | |||
| ZipFinder, | |||
| ) | |||
| if _HAS_MACHINERY and sys.version_info[:2] > (3, 3): | |||
| if _HAS_MACHINERY and sys.version_info[:2] > (3, 4): | |||
There was a problem hiding this comment.
I think here we intended to have >= 3.4, this will stop working on 3.4
There was a problem hiding this comment.
Good point, will fix! (There was no test failure so here's a gap in coverage.)
PCManticore
reviewed
Dec 11, 2017
astroid/tests/unittest_manager.py
Outdated
| @@ -26,7 +26,7 @@ | |||
| def _get_file_from_object(obj): | |||
| if platform.python_implementation() == 'Jython': | |||
| return obj.__file__.split("$py.class")[0] + ".py" | |||
| if sys.version_info > (3, 0): | |||
| if sys.version_info > (3, 4): | |||
There was a problem hiding this comment.
Yep, will change to >= (3, 4).
PCManticore
reviewed
Dec 11, 2017
astroid/tests/unittest_manager.py
Outdated
| @@ -104,7 +104,7 @@ def test_ast_from_namespace_pkgutil(self): | |||
| def test_ast_from_namespace_pkg_resources(self): | |||
| self._test_ast_from_old_namespace_package_protocol('pkg_resources') | |||
|
|
|||
| @unittest.skipUnless(sys.version_info[:2] > (3, 3), "Needs PEP 420 namespace protocol") | |||
| @unittest.skipUnless(sys.version_info[:2] > (3, 4), "Needs PEP 420 namespace protocol") | |||
There was a problem hiding this comment.
Ditto. I think namespace protocol landed in 3.4
PCManticore
requested changes
Dec 11, 2017
|
@PCManticore Thanks, I've updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest master is failing on Python 3.3 because pytest, or rather py, has dropped support for Python 3.3 (pytest-dev/py#159 pytest-dev/py#165):
https://travis-ci.org/hugovk/astroid/builds/309952810
Here's the pip installs for astroid from PyPI for the last month (via
pypinfo --percent --pip astroid pyversion) showing a small fraction on 3.3: