Skip to content

Commit

Permalink
Fix bot trigger event
Browse files Browse the repository at this point in the history
Issue events don't contain a 'comment' entry:
https://developer.github.com/v3/issues/events/#response-2

Issue comments also contain the original issue body:
https://developer.github.com/v3/activity/events/types/#issuecommentevent

That's why it was triggering even for comments on the issue.

Also changed to startsWith because there's no need to support
the command anywhere in the body IMO.

Fix #6895
  • Loading branch information
nicoddemus committed Mar 11, 2020
1 parent 4f8fff9 commit a0ea300
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release-on-comment.yml
Expand Up @@ -11,7 +11,7 @@ jobs:
build:
runs-on: ubuntu-latest

if: (github.event.comment && contains(github.event.comment.body, '@pytestbot please')) || (github.event.issue && contains(github.event.issue.body, '@pytestbot please'))
if: (github.event.comment && startsWith(github.event.comment.body, '@pytestbot please')) || (github.event.issue && !github.event.comment && startsWith(github.event.issue.body, '@pytestbot please'))

steps:
- uses: actions/checkout@v1
Expand Down

0 comments on commit a0ea300

Please sign in to comment.