Skip to content

Commit

Permalink
fixes for flake8 3.7
Browse files Browse the repository at this point in the history
  • Loading branch information
asottile committed Jan 30, 2019
1 parent 5119abe commit e5f823a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
3 changes: 3 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ repos:
- id: debug-statements
exclude: _pytest/debugging.py
language_version: python3
- repo: https://gitlab.com/pycqa/flake8
rev: 3.7.0
hooks:
- id: flake8
language_version: python3
- repo: https://github.com/asottile/reorder_python_imports
Expand Down
4 changes: 2 additions & 2 deletions src/_pytest/fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,8 @@ class FuncFixtureInfo(object):
# fixture names specified via usefixtures and via autouse=True in fixture
# definitions.
initialnames = attr.ib(type=tuple)
names_closure = attr.ib() # type: List[str]
name2fixturedefs = attr.ib() # type: List[str, List[FixtureDef]]
names_closure = attr.ib() # List[str]
name2fixturedefs = attr.ib() # List[str, List[FixtureDef]]

def prune_dependency_tree(self):
"""Recompute names_closure from initialnames and name2fixturedefs
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ def __init__(self, item):
"""Creates a new funcarg."""
self._item = item
# dict of log name -> log level
self._initial_log_levels = {} # type: Dict[str, int]
self._initial_log_levels = {} # Dict[str, int]

def _finalize(self):
"""Finalizes the fixture.
Expand Down
4 changes: 2 additions & 2 deletions src/_pytest/mark/structures.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ class Mark(object):
#: name of the mark
name = attr.ib(type=str)
#: positional arguments of the mark decorator
args = attr.ib() # type: List[object]
args = attr.ib() # List[object]
#: keyword arguments of the mark decorator
kwargs = attr.ib() # type: Dict[str, object]
kwargs = attr.ib() # Dict[str, object]

def combined_with(self, other):
"""
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ class CallInfo(object):
""" Result/Exception info a function invocation. """

_result = attr.ib()
# type: Optional[ExceptionInfo]
# Optional[ExceptionInfo]
excinfo = attr.ib()
start = attr.ib()
stop = attr.ib()
Expand Down

0 comments on commit e5f823a

Please sign in to comment.