Merge pull request #3277 from maiksensi/bug/3241-check-if-dir-exists

Use `isdir` instead of `exists`
pytest-dev · Mar 4, 2018 · e980fbb · e980fbb
2 parents 07e768a + 9a2e0c0
commit e980fbb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/_pytest/main.py b/_pytest/main.py
@@ -170,7 +170,7 @@ def _in_venv(path):
     """Attempts to detect if ``path`` is the root of a Virtual Environment by
     checking for the existence of the appropriate activate script"""
     bindir = path.join('Scripts' if sys.platform.startswith('win') else 'bin')
-    if not bindir.exists():
+    if not bindir.isdir():
         return False
     activates = ('activate', 'activate.csh', 'activate.fish',
                  'Activate', 'Activate.bat', 'Activate.ps1')

diff --git a/changelog/3241.bugfix.rst b/changelog/3241.bugfix.rst
@@ -0,0 +1,2 @@
+Refactor check of bindir from ``exists`` to ``isdir`` regarding `#3241 <https://github.com/pytest-dev/pytest/issues/3241>`_.
+