Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow progress console_output_style even when capture=no #10737

Open
reaperhulk opened this issue Feb 15, 2023 · 0 comments
Open

Allow progress console_output_style even when capture=no #10737

reaperhulk opened this issue Feb 15, 2023 · 0 comments
Labels
plugin: capture related to the capture builtin plugin type: performance performance or memory problem/improvement

Comments

@reaperhulk
Copy link
Contributor

reaperhulk commented Feb 15, 2023

What's the problem this feature will solve?

When running large test suites like pyca/cryptography we see significant (up to 40%!) slowdown on some jobs when capturing is enabled. However, enabling capture disables "progress" , which in turn results in extraordinarily long lines on GitHub Actions, which breaks browsers' ability to load CI output.

Describe the solution you'd like

In #3038 the "progress" output was disabled when capture=no (defaulting back to classic) because any extraneous stdout/stderr from the tests will mess up the output. However, for users who are willing to risk accidentally leaving code that might write to stdout/stderr it would be great to support a flag that would re-enable progress info.

Alternative Solutions

  • Capturing could possibly be made (much) faster, thus negating the desire to disable it to gain performance.
  • A new output style could exist which limits line lengths but does not attempt to do "progress" style fancy output.
@Zac-HD Zac-HD added type: performance performance or memory problem/improvement plugin: capture related to the capture builtin plugin labels Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: capture related to the capture builtin plugin type: performance performance or memory problem/improvement
Projects
None yet
Development

No branches or pull requests

2 participants