Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new-style pluggy hook wrappers #11122

Closed
bluetech opened this issue Jun 19, 2023 · 0 comments · Fixed by #11123
Closed

Switch to new-style pluggy hook wrappers #11122

bluetech opened this issue Jun 19, 2023 · 0 comments · Fixed by #11123
Assignees
@bluetech
Labels
type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature

Comments

@bluetech
Copy link
Member

bluetech commented Jun 19, 2023 •
edited

This is a new feature in pluggy 1.1.0: https://pluggy.readthedocs.io/en/latest/changelog.html#pluggy-1-1-0-2023-06-19

They are slightly cleaner, faster (if only new-style wrappers are used) and safer (better handling of exceptions thrown after the yield). They are fully interoperable with hookwrapper=True wrappers.

This will require pluggy>=1.1.0.
@bluetech bluetech added the type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature label Jun 19, 2023
@bluetech bluetech self-assigned this Jun 19, 2023
bluetech added a commit to bluetech/pytest that referenced this issue Jun 19, 2023
@bluetech
Switch to new-style pluggy hook wrappers
cdaa52c 
Fix pytest-dev#11122.
bluetech added a commit to bluetech/pytest that referenced this issue Jun 19, 2023
@bluetech
Switch to new-style pluggy hook wrappers
52c1a7e 
Fix pytest-dev#11122.
@bluetech bluetech mentioned this issue Jun 19, 2023
Merged
bluetech added a commit to bluetech/pytest that referenced this issue Jun 21, 2023
@bluetech
Switch to new-style pluggy hook wrappers
147ad6b 
Fix pytest-dev#11122.
bluetech added a commit to bluetech/pytest that referenced this issue Jun 21, 2023
@bluetech
Switch to new-style pluggy hook wrappers
d9290ce 
Fix pytest-dev#11122.
bluetech added a commit to bluetech/pytest that referenced this issue Jul 14, 2023
@bluetech
Switch to new-style pluggy hook wrappers
b41acae 
Fix pytest-dev#11122.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluetech bluetech

Labels
type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to new-style pluggy hook wrappers bluetech/pytest
1 participant
@bluetech