Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setup.py #11667

Closed
bluetech opened this issue Dec 4, 2023 · 1 comment · Fixed by #11668
Closed

Remove setup.py #11667

bluetech opened this issue Dec 4, 2023 · 1 comment · Fixed by #11668
Assignees
@bluetech
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: removal marks the actual removal of a feature, usually done in major releases

Comments

@bluetech
Copy link
Member

bluetech commented Dec 4, 2023

pytest's setup.py file is there for legacy purposes and is no longer necessary, see: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html. I believe the only reason to keep it keep direct setup.py install invocations and such working. I don't know if there are still places out there who do this, but pytest 8.0 seems like a good time to stop supporting it. So I propose doing that.
@bluetech bluetech added type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: removal marks the actual removal of a feature, usually done in major releases labels Dec 4, 2023
@bluetech bluetech self-assigned this Dec 4, 2023
@bluetech
Copy link
Member Author

bluetech commented Dec 4, 2023

I did this for pytest-django a few weeks ago and no complaints so far.

In pytest-django I also moved all of setup.cfg to pyproject.toml but I'm not proposing it for pytest, it's a more recent thing.

bluetech added a commit to bluetech/pytest that referenced this issue Dec 4, 2023
@bluetech
Remove setup.py
b8118ab 
Fix pytest-dev#11667.
@bluetech bluetech mentioned this issue Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluetech bluetech

Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: removal marks the actual removal of a feature, usually done in major releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove setup.py bluetech/pytest
1 participant
@bluetech