New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to explicitly specify the path of the root directory #1642

Closed
davehunt opened this Issue Jun 22, 2016 · 5 comments

Comments

Projects
None yet
6 participants
@davehunt
Contributor

davehunt commented Jun 22, 2016

The root directory discovery is convoluted, and there are cases where it fails to resolve to a suitable path. We should improve the discovery as much as possible, but it also makes sense to provide a way for users to explicitly specify the root directory.

We could add a --rootdir command line option, which would be relative to the invocation directory. We could also add a rootdir configuration key, which would override the command line option, and would be relative to the configuration file.

@RonnyPfannschmidt RonnyPfannschmidt added this to the 3.0 milestone Jun 27, 2016

@The-Compiler

This comment has been minimized.

Member

The-Compiler commented Aug 5, 2016

Didn't someone work on this during the sprint? Also, while this is a nice feature, it shouldn't block 3.0. Changing the milestone to 3.1 for now.

@feuillemorte

This comment has been minimized.

Member

feuillemorte commented Jan 17, 2018

I take it

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Jan 17, 2018

@feuillemorte awesome, let us know if you hit any roadblock. 👍

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Jan 17, 2018

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Jan 17, 2018

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Jan 17, 2018

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Jan 17, 2018

@feuillemorte

This comment has been minimized.

Member

feuillemorte commented Jan 18, 2018

#3127

All checks have passed

Please review :)

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Jan 20, 2018

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Jan 25, 2018

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Jan 25, 2018

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Jan 31, 2018

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Jan 31, 2018

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Jan 31, 2018

feuillemorte added a commit to feuillemorte/pytest that referenced this issue Feb 1, 2018

nicoddemus added a commit that referenced this issue Feb 7, 2018

@feuillemorte

This comment has been minimized.

Member

feuillemorte commented Feb 11, 2018

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment