Allow users to explicitly specify the path of the root directory #1642
Labels
good first issue
easy issue that is friendly to new contributor
type: enhancement
new feature or API change, should be merged into features branch
Milestone
Comments
blueyed
added
the
type: enhancement
|
Didn't someone work on this during the sprint? Also, while this is a nice feature, it shouldn't block 3.0. Changing the milestone to 3.1 for now. |
nicoddemus
added
the
good first issue
|
I take it |
|
@feuillemorte awesome, let us know if you hit any roadblock. 👍 |
|
All checks have passed Please review :) |
|
Merged |
jsirois
added a commit
to jsirois/pants
that referenced
this issue
May 21, 2019
+ Use `--rootdir` to set the rootdir ahead of time and use the buildroot
for sensible RHS paths in `-v` output (previously we only had sensible
LHS paths via the `NodeRenamerPlugin`). This option was introduced
relatively recently in 3.5.0:
https://docs.pytest.org/en/latest/changelog.html#pytest-3-5-0-2018-03-21
pytest-dev/pytest#1642
+ Control the `.pytest_cachedir` location with `-o` and move it into the
task workdir (defaults to the `--rootdir` otherwise).
+ Simplify `pytest.ini` nullification by pointing to os.devnull instead
of embedding an empty `pytest.ini` in the pytest pex.
jsirois
added a commit
to pantsbuild/pants
that referenced
this issue
May 22, 2019
+ Use `--rootdir` to set the rootdir ahead of time and use the buildroot
for sensible RHS paths in `-v` output (previously we only had sensible
LHS paths via the `NodeRenamerPlugin`). This option was introduced
relatively recently in 3.5.0:
https://docs.pytest.org/en/latest/changelog.html#pytest-3-5-0-2018-03-21
pytest-dev/pytest#1642
+ Control the `.pytest_cachedir` location with `-o` and move it into the
task workdir (defaults to the `--rootdir` otherwise).
+ Simplify `pytest.ini` nullification by pointing to os.devnull instead
of embedding an empty `pytest.ini` in the pytest pex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The root directory discovery is convoluted, and there are cases where it fails to resolve to a suitable path. We should improve the discovery as much as possible, but it also makes sense to provide a way for users to explicitly specify the root directory.
We could add a
--rootdircommand line option, which would be relative to the invocation directory. We could also add arootdirconfiguration key, which would override the command line option, and would be relative to the configuration file.The text was updated successfully, but these errors were encountered: