Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--last-failed and --failed-first precedence #2308

Closed
ojii opened this issue Mar 14, 2017 · 6 comments
Closed

--last-failed and --failed-first precedence #2308

ojii opened this issue Mar 14, 2017 · 6 comments

Comments

@ojii
Copy link
Contributor

@ojii ojii commented Mar 14, 2017

If I run pytest with --failed-first and --last-failed, all tests are run. This is unintuitive for me, since I actually include --failed-first in my pytest.ini so it defaults to running failed tests first. However, sometimes I just want to run the failed tests so I add --last-failed at the commend line, but that has no effect.

I think this behaviour should be changed to --last-failed taking precedence over --failed-first.

I'd be happy to provide a patch for this if there's an agreement that this is should be changed.

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Mar 14, 2017

this is a bugfix that would require a major release due to breaking behavior
i'm in favor, but would shoot a mail to the ml before working on a pr

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Mar 14, 2017

I agree that changing the behavior would make more sense and I can't think of a use-case for the existing behavior, so I'm 👍.

@flub
Copy link
Member

@flub flub commented Mar 28, 2017

Another +1 from me. If you'd like to have a go at submitting a patch that would be great.

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Mar 28, 2017

i submit https://xkcd.com/1172/ for version number considerations ^^

@ojii
Copy link
Contributor Author

@ojii ojii commented Apr 10, 2017

Submitted #2357

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Apr 11, 2017

Fixed by #2357, thanks again @ojii!

This was referenced Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants