ensure callspecs contain the list of marks #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
requested review from
nicoddemus,
The-Compiler and
hpk42
and removed request for
nicoddemus
RonnyPfannschmidt
force-pushed
the
mark-callspeck
branch
from
df81b08
to
c09055c
Compare
RonnyPfannschmidt
added a commit
to RonnyPfannschmidt/pytest
that referenced
this pull request
Aug 10, 2017
nicoddemus
approved these changes
Aug 10, 2017
| @@ -67,10 +67,6 @@ def extract_from(cls, parameterset, legacy_force_tuple=False): | |||
|
|
|||
| return cls(argval, marks=newmarks, id=None) | |||
|
|
|||
| @property | |||
| def deprecated_arg_dict(self): | |||
There was a problem hiding this comment.
I suppose this was never part of the public API given that it is a method of the new ParameterSet class, but if I'm wrong then we should add a removal changelog note.
There was a problem hiding this comment.
it was a naming error, but we should add a removal message anyway
changelog/2672.removal
Outdated
| @@ -0,0 +1 @@ | |||
| Internally change CallSpec2 to have a list of marks instead of a broken mapping of keywords | |||
There was a problem hiding this comment.
Nit: add a . a the end of the sentence. 😁
RonnyPfannschmidt
force-pushed
the
mark-callspeck
branch
from
c09055c
to
eb46258
Compare
nicoddemus
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ensures we don't override in that area
the final parts of the transfer are still broken, but with the list, we at least have a chance to do better in future
this is also base to fix #1540 in future