Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getfuncargvalue deprecation warning does set the proper stacklevel #2681

Closed
pelme opened this issue Aug 13, 2017 · 2 comments
Closed

getfuncargvalue deprecation warning does set the proper stacklevel #2681

pelme opened this issue Aug 13, 2017 · 2 comments

Comments

@pelme
Copy link
Member

@pelme pelme commented Aug 13, 2017

Calling request.getfuncargvalue() gives this rather unhelpful message which makes it hard to figure out where the call happens:

...

=== warnings summary ===
system/test_asdf.py::test_fghj
  /bla/bla/bla/_pytest/fixtures.py:431: DeprecationWarning: use of getfuncargvalue is deprecated, use getfixturevalue
    DeprecationWarning)
@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Aug 13, 2017

@pelme i wonder if we have other warnings with that mistake as well

@pelme
Copy link
Member Author

@pelme pelme commented Aug 13, 2017

I did not look into it at this point. I have just been annoyed by this single instance for a while but not gotten around to fixing it.

Btw, I think stacklevel=2 would be a saner default in Python but anyways...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants