Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #3015

Merged
merged 11 commits into from
Dec 12, 2017
Merged

Code cleanup #3015

merged 11 commits into from
Dec 12, 2017

Conversation

jurko-gospodnetic
Copy link
Contributor

Code cleanup done while working on another pull request and extracted here so it would not cloud up the original pull request.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.7% when pulling 855b4af on jurko-gospodnetic:code-cleanup into 1c5b887 on pytest-dev:master.

@jurko-gospodnetic jurko-gospodnetic force-pushed the code-cleanup branch 2 times, most recently from a73fbde to c278b47 Compare December 8, 2017 22:51
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.7% when pulling 855b4af on jurko-gospodnetic:code-cleanup into 1c5b887 on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.7% when pulling a73fbde on jurko-gospodnetic:code-cleanup into 1c5b887 on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.7% when pulling c278b47 on jurko-gospodnetic:code-cleanup into 1c5b887 on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.7% when pulling 73bc6ba on jurko-gospodnetic:code-cleanup into 964c29c on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.7% when pulling 73bc6ba on jurko-gospodnetic:code-cleanup into 964c29c on pytest-dev:master.

# mixed module and filenames:
os.chdir('world')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code<> commend swap looks unintended

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I thought it seemed correct - there are two pytest runs here and for each we set up a suitable cwd folder

easy enough to revert if you dislike it, I'm just curious as to what the intended meaning here was then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, in full context it looks correct after all - before this change the lines where directly matching the code in question, but now its indeed marking the test sections instead

@RonnyPfannschmidt
Copy link
Member

overall good work on many many little details 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.7% when pulling 3b85e0c on jurko-gospodnetic:code-cleanup into 964c29c on pytest-dev:master.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks @jurko-gospodnetic!

@nicoddemus nicoddemus merged commit 5c6d773 into pytest-dev:master Dec 12, 2017
@jurko-gospodnetic jurko-gospodnetic deleted the code-cleanup branch December 12, 2017 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants