Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal refactor port exc FOrmattedExcinfo to attrs, remove old code #3292

Merged
merged 8 commits into from
Mar 12, 2018
Merged

internal refactor port exc FOrmattedExcinfo to attrs, remove old code #3292

merged 8 commits into from
Mar 12, 2018

Conversation

RonnyPfannschmidt
Copy link
Member

No description provided.

@RonnyPfannschmidt RonnyPfannschmidt changed the base branch from master to features March 9, 2018 13:42
@coveralls
Copy link

coveralls commented Mar 9, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 92.957% when pulling d2dbbd4 on RonnyPfannschmidt:exception-attrs into d6ddeb3 on pytest-dev:features.

nicoddemus
nicoddemus approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Fixed linting and added a CHANGELOG entry. 👍

@nicoddemus
Copy link
Member

(Since it is marked as WIP, I will wait for @RonnyPfannschmidt's signal to merge)

@RonnyPfannschmidt RonnyPfannschmidt changed the title [wip] port exc eptioninfo to attrs internal refactor port exc FOrmattedExcinfo to attrs, remove old code Mar 10, 2018
@nicoddemus nicoddemus merged commit f8791c9 into pytest-dev:features Mar 12, 2018
@RonnyPfannschmidt RonnyPfannschmidt deleted the exception-attrs branch October 1, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RonnyPfannschmidt @coveralls @nicoddemus