Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal refactor port exc FOrmattedExcinfo to attrs, remove old code #3292

Merged
merged 8 commits into from Mar 12, 2018

Conversation

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Mar 9, 2018

No description provided.

@RonnyPfannschmidt RonnyPfannschmidt changed the base branch from master to features Mar 9, 2018
@coveralls
Copy link

@coveralls coveralls commented Mar 9, 2018

Coverage Status

Coverage increased (+0.3%) to 92.957% when pulling d2dbbd4 on RonnyPfannschmidt:exception-attrs into d6ddeb3 on pytest-dev:features.

Copy link
Member

@nicoddemus nicoddemus left a comment

Nice cleanup! Fixed linting and added a CHANGELOG entry. 👍

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Mar 10, 2018

(Since it is marked as WIP, I will wait for @RonnyPfannschmidt's signal to merge)

@RonnyPfannschmidt RonnyPfannschmidt changed the title [wip] port exc eptioninfo to attrs internal refactor port exc FOrmattedExcinfo to attrs, remove old code Mar 10, 2018
@nicoddemus nicoddemus merged commit f8791c9 into pytest-dev:features Mar 12, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RonnyPfannschmidt RonnyPfannschmidt deleted the RonnyPfannschmidt:exception-attrs branch Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants