Don't create tmpdir simlink if --basetemp is used

[anxuae]

Using the option --basetemp has the consequence to create a link to each temporary directory, thus double the quantity of folders and let the temp directory less readable.

These link are generated by the method py.path.local.LocalPath.make_numbered_dir (see pytest-dev/py#194)

Configuration

• Ubuntu 14.04
• pytest version 3.6.0

[pytestbot]

GitMate.io thinks possibly related issues are #617 (Iterative tmpdir folders lost when using --basetemp), #444 (tmpdir: Use pathlib instead of py.path), #1120 (Cleaning up tmpdir's), #543 (Should tmpdir clean up after itself?), and #1784 (pytest_assertrepr_compare not being used?).

[0cjs]

My experience has been that it creates only one link, removing it and recreating it for each use of the tmpdir fixture. But this may be related to the particular path you pass to --basetemp and where you have (or don't have) hyphens in it.

As I described in my comment on pytest-dev/py#194, my workaround was to ensure that the last component of the path I pass to --basetemp includes a hyphen, e.g., --basetemp=my-repo/.build/pytest/tmpdir-top, which will create just one my-repo/.build/pytest/tmpdir-current or similar link pointing to the tmpdir for the most recently run test.