junitxml parses report.nodeid incorrectly #469

pytestbot · 2014-02-25T14:19:15Z

Originally reported by: Andrei Baidarov (BitBucket: tIGO, GitHub: tIGO)

If test param contains '::' junitxml parses report.nodeid incorrectly. For example, for test

#!python

import pytest

@pytest.mark.parametrize('foo', ['1::2'])
def testA(foo):
    assert True

py.test --junitxml=1 test.py produces xml with classname="test.testA[1" and name="2]" instead of classname="test" and name="testA[1::2]".

Bitbucket: https://bitbucket.org/pytest-dev/pytest/issue/469

The text was updated successfully, but these errors were encountered:

RonnyPfannschmidt · 2016-01-01T13:34:11Z

Due to implementation details this s one is flaky to fix

tomviner · 2016-03-01T15:55:02Z

Could you take a look at this @RonnyPfannschmidt
master...tomviner:issue469-junit-double-colon

If it's a reasonable start, I'll create a PR, so we can discuss the detail line by line as required.

RonnyPfannschmidt · 2016-03-02T08:02:27Z

I would propose to move all logic to the mangle-names function, and directly passing it the nodeid

tomviner · 2016-03-02T21:30:06Z

Yes that's a very reasonable point. PR #1431

2.9.1 ===== **Bug Fixes** * Improve error message when a plugin fails to load. Thanks `@nicoddemus`_ for the PR. * Fix (`#1178 <https://github.com/pytest-dev/pytest/issues/1178>`_): ``pytest.fail`` with non-ascii characters raises an internal pytest error. Thanks `@nicoddemus`_ for the PR. * Fix (`#469`_): junit parses report.nodeid incorrectly, when params IDs contain ``::``. Thanks `@tomviner`_ for the PR (`#1431`_). * Fix (`#578 <https://github.com/pytest-dev/pytest/issues/578>`_): SyntaxErrors containing non-ascii lines at the point of failure generated an internal py.test error. Thanks `@asottile`_ for the report and `@nicoddemus`_ for the PR. * Fix (`#1437`_): When passing in a bytestring regex pattern to parameterize attempt to decode it as utf-8 ignoring errors. * Fix (`#649`_): parametrized test nodes cannot be specified to run on the command line. .. _#1437: pytest-dev/pytest#1437 .. _#469: pytest-dev/pytest#469 .. _#1431: pytest-dev/pytest#1431 .. _#649: pytest-dev/pytest#649 .. _@asottile: https://github.com/asottile 2.9.0 ===== **New Features** * New ``pytest.mark.skip`` mark, which unconditionally skips marked tests. Thanks `@MichaelAquilina`_ for the complete PR (`#1040`_). * ``--doctest-glob`` may now be passed multiple times in the command-line. Thanks `@jab`_ and `@nicoddemus`_ for the PR. * New ``-rp`` and ``-rP`` reporting options give the summary and full output of passing tests, respectively. Thanks to `@codewarrior0`_ for the PR. * ``pytest.mark.xfail`` now has a ``strict`` option, which makes ``XPASS`` tests to fail the test suite (defaulting to ``False``). There's also a ``xfail_strict`` ini option that can be used to configure it project-wise. Thanks `@rabbbit`_ for the request and `@nicoddemus`_ for the PR (`#1355`_). * ``Parser.addini`` now supports options of type ``bool``. Thanks `@nicoddemus`_ for the PR. * New ``ALLOW_BYTES`` doctest option. This strips ``b`` prefixes from byte strings in doctest output (similar to ``ALLOW_UNICODE``). Thanks `@jaraco`_ for the request and `@nicoddemus`_ for the PR (`#1287`_). * Give a hint on ``KeyboardInterrupt`` to use the ``--fulltrace`` option to show the errors. Fixes `#1366`_. Thanks to `@hpk42`_ for the report and `@RonnyPfannschmidt`_ for the PR. * Catch ``IndexError`` exceptions when getting exception source location. Fixes a pytest internal error for dynamically generated code (fixtures and tests) where source lines are fake by intention. **Changes** * **Important**: `py.code <http://pylib.readthedocs.org/en/latest/code.html>`_ has been merged into the ``pytest`` repository as ``pytest._code``. This decision was made because ``py.code`` had very few uses outside ``pytest`` and the fact that it was in a different repository made it difficult to fix bugs on its code in a timely manner. The team hopes with this to be able to better refactor out and improve that code. This change shouldn't affect users, but it is useful to let users aware if they encounter any strange behavior. Keep in mind that the code for ``pytest._code`` is **private** and **experimental**, so you definitely should not import it explicitly! Please note that the original ``py.code`` is still available in `pylib <http://pylib.readthedocs.org>`_. * ``pytest_enter_pdb`` now optionally receives the pytest config object. Thanks `@nicoddemus`_ for the PR. * Removed code and documentation for Python 2.5 or lower versions, including removal of the obsolete ``_pytest.assertion.oldinterpret`` module. Thanks `@nicoddemus`_ for the PR (`#1226`_). * Comparisons now always show up in full when ``CI`` or ``BUILD_NUMBER`` is found in the environment, even when ``-vv`` isn't used. Thanks `@The-Compiler`_ for the PR. * ``--lf`` and ``--ff`` now support long names: ``--last-failed`` and ``--failed-first`` respectively. Thanks `@MichaelAquilina`_ for the PR. * Added expected exceptions to ``pytest.raises`` fail message. * Collection only displays progress ("collecting X items") when in a terminal. This avoids cluttering the output when using ``--color=yes`` to obtain colors in CI integrations systems (`#1397`_). **Bug Fixes** * The ``-s`` and ``-c`` options should now work under ``xdist``; ``Config.fromdictargs`` now represents its input much more faithfully. Thanks to `@bukzor`_ for the complete PR (`#680`_). * Fix (`#1290`_): support Python 3.5's ``@`` operator in assertion rewriting. Thanks `@Shinkenjoe`_ for report with test case and `@tomviner`_ for the PR. * Fix formatting utf-8 explanation messages (`#1379`_). Thanks `@biern`_ for the PR. * Fix `traceback style docs`_ to describe all of the available options (auto/long/short/line/native/no), with `auto` being the default since v2.6. Thanks `@hackebrot`_ for the PR. * Fix (`#1422`_): junit record_xml_property doesn't allow multiple records with same name. .. _`traceback style docs`: https://pytest.org/latest/usage.html#modifying-python-traceback-printing .. _#1422: pytest-dev/pytest#1422 .. _#1379: pytest-dev/pytest#1379 .. _#1366: pytest-dev/pytest#1366 .. _#1040: pytest-dev/pytest#1040 .. _#680: pytest-dev/pytest#680 .. _#1287: pytest-dev/pytest#1287 .. _#1226: pytest-dev/pytest#1226 .. _#1290: pytest-dev/pytest#1290 .. _#1355: pytest-dev/pytest#1355 .. _#1397: pytest-dev/pytest#1397 .. _@biern: https://github.com/biern .. _@MichaelAquilina: https://github.com/MichaelAquilina .. _@bukzor: https://github.com/bukzor .. _@hpk42: https://github.com/hpk42 .. _@nicoddemus: https://github.com/nicoddemus .. _@jab: https://github.com/jab .. _@codewarrior0: https://github.com/codewarrior0 .. _@jaraco: https://github.com/jaraco .. _@The-Compiler: https://github.com/The-Compiler .. _@Shinkenjoe: https://github.com/Shinkenjoe .. _@tomviner: https://github.com/tomviner .. _@RonnyPfannschmidt: https://github.com/RonnyPfannschmidt .. _@rabbbit: https://github.com/rabbbit .. _@hackebrot: https://github.com/hackebrot

pytestbot added the type: bug problem that needs to be addressed label Jun 15, 2015

RonnyPfannschmidt added the topic: reporting related to terminal output and user-facing messages and errors label Jan 1, 2016

RonnyPfannschmidt added status: help wanted developers would like help from experts on this topic good first issue easy issue that is friendly to new contributor labels Jan 1, 2016

tomviner mentioned this issue Mar 2, 2016

issue469: add fix junit double colon split issue #1431

Merged

RonnyPfannschmidt closed this as completed in 7aa7c6b Mar 3, 2016

pyup-bot mentioned this issue Jun 9, 2016

Initial Update pydanny/cached-property#33

Merged

pyup-bot mentioned this issue Jul 19, 2016

Initial Update alexandre-old/flask-rest-template#20

Merged

This was referenced Jul 26, 2016

Initial Update SpamExperts/se-dns#1

Closed

Initial Update SpamExperts/spoon#1

Closed

pyup-bot mentioned this issue Aug 13, 2016

Initial Update maartenq/clustercron#2

Closed

This was referenced Aug 23, 2016

Pin pytest to latest version 3.0.0 bonclay7/aws-amicleaner#30

Closed

Pin pytest to latest version 3.0.1 bonclay7/aws-amicleaner#39

Closed

This was referenced Sep 15, 2017

Initial Update OnroerendErfgoed/crabpy#80

Merged

Pin pytest to latest version 3.2.2 SekouD/lyricsmaster#6

Merged

Initial Update DonDebonair/slack-machine#2

Merged

This was referenced Oct 16, 2017

Pin pytest to latest version 3.2.3 zenotech/epic-cli#42

Merged

Initial Update praekeltfoundation/django-py-zipkin#1

Merged

dependencies bot mentioned this issue Nov 4, 2017

Update pytest in requirements-dev.txt from 2.8.0 to 2.9.2 tjamet/caduc#4

Merged

This was referenced Nov 20, 2017

Initial Update OnroerendErfgoed/skosprovider_rdf#27

Merged

Pin pytest to latest version 3.2.5 Opentrons/opentrons#443

Closed

fkohlgrueber pushed a commit to fkohlgrueber/pytest that referenced this issue Oct 27, 2018

change some numeric behavior (pytest-dev#469)

a37abdc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

junitxml parses report.nodeid incorrectly #469

junitxml parses report.nodeid incorrectly #469

pytestbot commented Feb 25, 2014

RonnyPfannschmidt commented Jan 1, 2016

tomviner commented Mar 1, 2016

RonnyPfannschmidt commented Mar 2, 2016

tomviner commented Mar 2, 2016

junitxml parses report.nodeid incorrectly #469

junitxml parses report.nodeid incorrectly #469

Comments

pytestbot commented Feb 25, 2014

RonnyPfannschmidt commented Jan 1, 2016

tomviner commented Mar 1, 2016

RonnyPfannschmidt commented Mar 2, 2016

tomviner commented Mar 2, 2016