Allow registering marks using regex

[lhupfeldt]

Because of integration with a test management/reporting system we have a lot of generated marks consisting of a prefix and a number. I'm submitting a pull request to allow registering marks using regex (or any object with a match() method)

[asottile]

closing for now given the resolution in #5571

[RonnyPfannschmidt]

reopening as this is a detail the next iteration of marker registration should take into account
@lhupfeldt would it be a option to pass the number as first argument to a mark instead

aka mark.FOO(123) instead of mark.FOO_123

[lhupfeldt]

Unfortunately we cannot control all the marks. A unique mark is added to each test by our test management tool and those have '_'.

…

On Thu, 11 Jul 2019, 06:19 Ronny Pfannschmidt, ***@***.***> wrote: reopening as this is a detail the next iteration of marker registration should take into account @lhupfeldt <https://github.com/lhupfeldt> would it be a option to pass the number as first argument to a mark instead aka mark.FOO(123) instead of mark.FOO_123) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5570?email_source=notifications&email_token=AAMCZSKTW53EQGF4YK62ZQLP62YF5A5CNFSM4H6WPJU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZVOSIA#issuecomment-510322976>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMCZSMLZ7POLQWOC4YR7ODP62YF5ANCNFSM4H6WPJUQ> .

[RonnyPfannschmidt]

@lhupfeldt to me it seems that mapping between FOO(x) and FOO_x might be trivial,

is there anything preventing you from mapping the test tools FOO_x to Foo(x) ?

[lhupfeldt]

Note that the marks are added in cucumber style feature files being imported/exported to/from our test management tool. The tool adds the during export. I think the simplest solution is really to allow registering marks using regex. If this is exposed as a function to be used instead of the addiniline then is should be possible to provide a nice inter face. Btw. the filterwarnings already allows regex in the ini file, the same syntax can be reused here.

…

On Thu, 11 Jul 2019, 13:26 Ronny Pfannschmidt, ***@***.***> wrote: @lhupfeldt <https://github.com/lhupfeldt> to me it seems that mapping between FOO(x) and FOO_x might be trivial, is there anything preventing you from mapping the test tools FOO_x to Foo(x) ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5570?email_source=notifications&email_token=AAMCZSIKACBS7MDUNSOK5TLP64KE5A5CNFSM4H6WPJU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZWMXFY#issuecomment-510446487>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMCZSIS7WH2LTNRSSTTBRDP64KE5ANCNFSM4H6WPJUQ> .

[RonnyPfannschmidt]

thanks for the input, we can work with that

[pfctdayelise]

I've been thinking about this. Maybe an alternative to fancy ways of registering marks is adding a hook like pytest_validate_mark?

[RonnyPfannschmidt]

i like that idea, i would like to see of we can get that integrated with ideas for the object based markers that are floating since a while and should solidify