Plurality matching #5990

MarcoGorelli · 2019-10-18T13:10:34Z

Fixes #5989 .

I presume this is small enough that I shouldn't add it to the changelog (or myself to the authors), but please do let me know if I should.

The-Compiler · 2019-10-18T13:20:55Z

Nice work! IMHO this is big enough for a changelog/author entry! However, the tests are currently failing - it seems like there are other places which you adjusted in the tests (e.g. "1 errors during collection" -> "1 error during collection") but not in the code. Could you take a look at the failing tests?

MarcoGorelli · 2019-10-18T13:43:12Z

Thanks! Yes, just working on it, I'll ping you when it's ready.

nicoddemus · 2019-10-18T14:17:18Z

src/_pytest/terminal.py

@@ -1007,6 +1007,14 @@ def _folded_skips(skipped):
    return values


+def _match_plurality(count, key):


I think it makes more sense to always pass the key as singular, and add s as necessary:

def _make_plural(noun, count): return noun + "s" if count != 1 else noun

This of course requires a change in the key themselves, but I believe this to be more elegant. What do you think?

Yes, _make_plural is an easier-to-understand name, thanks. I've kept the guard in though as we wouldn't want to add an 's' to the end of 'skipped', for example.

This of course requires a change in the key themselves, but I believe this to be more elegant. What do you think?

How backwards-compatible would that be (warnings -> warning) for e.g. plugins?

It might cause minor breakages for plugins testing things with testdir, depending on the test, good point.

To be on the safe side we should target features instead and get this out in 5.3. @MarcoGorelli could you rebase on features and change the target branch of the PR? Thanks!

changed the base branch from master to features

@MarcoGorelli
You also need to rebase it on features then (and force-push).

Do not add a commit that removes the changes (31af969), but rebase it so that only your commit(s) are there.

Ok, is it right now? (sorry, bit of a git-rebase noob here)

Anyway, thanks to you all for your time! :)

Better.. but the commit message needs adjustments.. ;)

nicoddemus · 2019-10-18T14:17:49Z

changelog/5990.improvement.rst

@@ -0,0 +1 @@
+Fix plurality mismatch in test summary (e.g. display "2 errors" instead of "2 error").


This is actually the other way around:

Fix plurality mismatch in test summary (e.g. display "1 error" instead of "1 errors").

Good catch, thanks!

kalekundert · 2019-10-18T15:11:19Z

I may be a little late to the game here, but I wanted to share a snippet of code I use to get plurality right in my scripts. I really like how succinct and flexible it is:

class plural:
    """
    The format string has three sections, separated by '/'.  The first section 
    is always printed, the second (optional) section is printed if the number 
    is singular, and the third section is printed if the number is plural.  Any 
    '?' in the format string are replaced with the actual number.

    >>> "I have {:? thing/s}.".format(plural(1))
    I have 1 thing.
    >>> "I have {:? thing/s}.".format(plural(2))
    I have 2 things.

    >>> "I want {:/a cactus/? cacti}.".format(plural(1))
    I want a cactus.
    >>> "I want {:/a cactus/? cacti}.".format(plural(2))
    I want 2 cacti.

    If the provided object supports len() (e.g. lists, dicts, etc.), then that 
    value is automatically used as the number:

    >>> "I have {:? thing/s}.".format(plural([3]))
    I have 1 thing.
    >>> "I have {:? thing/s}.".format(plural([3,4]))
    I have 2 things.

    From Veedrac on Stack Overflow (with some modifications): 
    http://stackoverflow.com/questions/21872366/plural-string-formatting
    """
    def __init__(self, value):
        self.value = value

    def __format__(self, formatter):
        from collections.abc import Sized

        x = self.value
        number = len(x) if isinstance(x, Sized) else self.value
        formatter = formatter.replace("?", str(number))
        always, _, suffixes = formatter.partition("/")
        singular, _, plural = suffixes.rpartition("/")

        return "{}{}".format(always, singular if number == 1 else plural)

I have this snippet on PyPI (nonstdlib.plural), but if you want to use it in pytest, I think it would be better to avoid a dependency for something so trivial.

blueyed · 2019-10-18T16:42:03Z

src/_pytest/terminal.py

 def build_summary_stats_line(stats):
    known_types = (
-        "failed passed skipped deselected xfailed xpassed warnings error".split()
+        "failed passed skipped deselected xfailed xpassed warning error".split()


That's an unnecessary API breakage, isn't it? I.e. plugins might use stats.get("warnings").
I think we should handle/set both then still, but can use "warning" only internally then.

MarcoGorelli · 2019-10-18T18:17:06Z

Hi all - just FYI, I'm away until the 26th of October, I'll finish this after that. Thanks for your patience in helping me get it right!

MarcoGorelli · 2019-10-27T19:41:50Z

I've updated the PR so it's a single commit which targets the features branch.

I've kept the API the same (so stats.get('warnings') continues to work), only changing it to warning within the scope of _make_plural.

blueyed

Thanks!

blueyed · 2019-10-28T16:03:51Z

Went ahead with merging when noticing the issue with #6094 .. :)
Thanks!

79: Update pytest to 5.3.0 r=duckinator a=pyup-bot This PR updates [pytest](https://pypi.org/project/pytest) from **5.2.4** to **5.3.0**. <details> <summary>Changelog</summary> ### 5.3.0 ``` ========================= Deprecations ------------ - `6179 <https://github.com/pytest-dev/pytest/issues/6179>`_: The default value of ``junit_family`` option will change to ``xunit2`` in pytest 6.0, given that this is the version supported by default in modern tools that manipulate this type of file. In order to smooth the transition, pytest will issue a warning in case the ``--junitxml`` option is given in the command line but ``junit_family`` is not explicitly configured in ``pytest.ini``. For more information, `see the docs <https://docs.pytest.org/en/latest/deprecations.htmljunit-family-default-value-change-to-xunit2>`__. Features -------- - `4488 <https://github.com/pytest-dev/pytest/issues/4488>`_: The pytest team has created the `pytest-reportlog <https://github.com/pytest-dev/pytest-reportlog>`__ plugin, which provides a new ``--report-log=FILE`` option that writes *report logs* into a file as the test session executes. Each line of the report log contains a self contained JSON object corresponding to a testing event, such as a collection or a test result report. The file is guaranteed to be flushed after writing each line, so systems can read and process events in real-time. The plugin is meant to replace the ``--resultlog`` option, which is deprecated and meant to be removed in a future release. If you use ``--resultlog``, please try out ``pytest-reportlog`` and provide feedback. - `4730 <https://github.com/pytest-dev/pytest/issues/4730>`_: When ``sys.pycache_prefix`` (Python 3.8+) is set, it will be used by pytest to cache test files changed by the assertion rewriting mechanism. This makes it easier to benefit of cached ``.pyc`` files even on file systems without permissions. - `5515 <https://github.com/pytest-dev/pytest/issues/5515>`_: Allow selective auto-indentation of multiline log messages. Adds command line option ``--log-auto-indent``, config option ``log_auto_indent`` and support for per-entry configuration of indentation behavior on calls to ``logging.log()``. Alters the default for auto-indention from ``on`` to ``off``. This restores the older behavior that existed prior to v4.6.0. This reversion to earlier behavior was done because it is better to activate new features that may lead to broken tests explicitly rather than implicitly. - `5914 <https://github.com/pytest-dev/pytest/issues/5914>`_: ``pytester`` learned two new functions, `no_fnmatch_line <https://docs.pytest.org/en/latest/reference.html_pytest.pytester.LineMatcher.no_fnmatch_line>`_ and `no_re_match_line <https://docs.pytest.org/en/latest/reference.html_pytest.pytester.LineMatcher.no_re_match_line>`_. The functions are used to ensure the captured text *does not* match the given pattern. The previous idiom was to use ``re.match``: .. code-block:: python assert re.match(pat, result.stdout.str()) is None Or the ``in`` operator: .. code-block:: python assert text in result.stdout.str() But the new functions produce best output on failure. - `6057 <https://github.com/pytest-dev/pytest/issues/6057>`_: Added tolerances to complex values when printing ``pytest.approx``. For example, ``repr(pytest.approx(3+4j))`` returns ``(3+4j) ± 5e-06 ∠ ±180°``. This is polar notation indicating a circle around the expected value, with a radius of 5e-06. For ``approx`` comparisons to return ``True``, the actual value should fall within this circle. - `6061 <https://github.com/pytest-dev/pytest/issues/6061>`_: Added the pluginmanager as an argument to ``pytest_addoption`` so that hooks can be invoked when setting up command line options. This is useful for having one plugin communicate things to another plugin, such as default values or which set of command line options to add. Improvements ------------ - `5061 <https://github.com/pytest-dev/pytest/issues/5061>`_: Use multiple colors with terminal summary statistics. - `5630 <https://github.com/pytest-dev/pytest/issues/5630>`_: Quitting from debuggers is now properly handled in ``doctest`` items. - `5924 <https://github.com/pytest-dev/pytest/issues/5924>`_: Improved verbose diff output with sequences. Before: .. code-block:: E AssertionError: assert ['version', '...version_info'] == ['version', '...version', ...] E Right contains 3 more items, first extra item: ' ' E Full diff: E - ['version', 'version_info', 'sys.version', 'sys.version_info'] E + ['version', E + 'version_info', E + 'sys.version', E + 'sys.version_info', E + ' ', E + 'sys.version', E + 'sys.version_info'] After: .. code-block:: E AssertionError: assert ['version', '...version_info'] == ['version', '...version', ...] E Right contains 3 more items, first extra item: ' ' E Full diff: E [ E 'version', E 'version_info', E 'sys.version', E 'sys.version_info', E + ' ', E + 'sys.version', E + 'sys.version_info', E ] - `5936 <https://github.com/pytest-dev/pytest/issues/5936>`_: Display untruncated assertion message with ``-vv``. - `5990 <https://github.com/pytest-dev/pytest/issues/5990>`_: Fixed plurality mismatch in test summary (e.g. display "1 error" instead of "1 errors"). - `6008 <https://github.com/pytest-dev/pytest/issues/6008>`_: ``Config.InvocationParams.args`` is now always a ``tuple`` to better convey that it should be immutable and avoid accidental modifications. - `6023 <https://github.com/pytest-dev/pytest/issues/6023>`_: ``pytest.main`` now returns a ``pytest.ExitCode`` instance now, except for when custom exit codes are used (where it returns ``int`` then still). - `6026 <https://github.com/pytest-dev/pytest/issues/6026>`_: Align prefixes in output of pytester's ``LineMatcher``. - `6059 <https://github.com/pytest-dev/pytest/issues/6059>`_: Collection errors are reported as errors (and not failures like before) in the terminal's short test summary. - `6069 <https://github.com/pytest-dev/pytest/issues/6069>`_: ``pytester.spawn`` does not skip/xfail tests on FreeBSD anymore unconditionally. - `6097 <https://github.com/pytest-dev/pytest/issues/6097>`_: The "[XXX%]" indicator in the test summary is now colored according to the final (new) multi-colored line's main color. - `6116 <https://github.com/pytest-dev/pytest/issues/6116>`_: Added ``--co`` as a synonym to ``--collect-only``. - `6148 <https://github.com/pytest-dev/pytest/issues/6148>`_: ``atomicwrites`` is now only used on Windows, fixing a performance regression with assertion rewriting on Unix. - `6152 <https://github.com/pytest-dev/pytest/issues/6152>`_: Now parametrization will use the ``__name__`` attribute of any object for the id, if present. Previously it would only use ``__name__`` for functions and classes. - `6176 <https://github.com/pytest-dev/pytest/issues/6176>`_: Improved failure reporting with pytester's ``Hookrecorder.assertoutcome``. - `6181 <https://github.com/pytest-dev/pytest/issues/6181>`_: The reason for a stopped session, e.g. with ``--maxfail`` / ``-x``, now gets reported in the test summary. - `6206 <https://github.com/pytest-dev/pytest/issues/6206>`_: Improved ``cache.set`` robustness and performance. Bug Fixes --------- - `2049 <https://github.com/pytest-dev/pytest/issues/2049>`_: Fixed ``--setup-plan`` showing inaccurate information about fixture lifetimes. - `2548 <https://github.com/pytest-dev/pytest/issues/2548>`_: Fixed line offset mismatch of skipped tests in terminal summary. - `6039 <https://github.com/pytest-dev/pytest/issues/6039>`_: The ``PytestDoctestRunner`` is now properly invalidated when unconfiguring the doctest plugin. This is important when used with ``pytester``'s ``runpytest_inprocess``. - `6047 <https://github.com/pytest-dev/pytest/issues/6047>`_: BaseExceptions are now handled in ``saferepr``, which includes ``pytest.fail.Exception`` etc. - `6074 <https://github.com/pytest-dev/pytest/issues/6074>`_: pytester: fixed order of arguments in ``rm_rf`` warning when cleaning up temporary directories, and do not emit warnings for errors with ``os.open``. - `6189 <https://github.com/pytest-dev/pytest/issues/6189>`_: Fixed result of ``getmodpath`` method. Trivial/Internal Changes ------------------------ - `4901 <https://github.com/pytest-dev/pytest/issues/4901>`_: ``RunResult`` from ``pytester`` now displays the mnemonic of the ``ret`` attribute when it is a valid ``pytest.ExitCode`` value. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details> Co-authored-by: pyup-bot <github-bot@pyup.io>

105: Update pytest to 5.3.1 r=rehandalal a=pyup-bot This PR updates [pytest](https://pypi.org/project/pytest) from **5.2.4** to **5.3.1**. <details> <summary>Changelog</summary> ### 5.3.1 ``` ========================= Improvements ------------ - `6231 <https://github.com/pytest-dev/pytest/issues/6231>`_: Improve check for misspelling of ``pytest.mark.parametrize``. - `6257 <https://github.com/pytest-dev/pytest/issues/6257>`_: Handle `exit.Exception` raised in `notify_exception` (via `pytest_internalerror`), e.g. when quitting pdb from post mortem. Bug Fixes --------- - `5914 <https://github.com/pytest-dev/pytest/issues/5914>`_: pytester: fix ``no_fnmatch_line`` when used after positive matching. - `6082 <https://github.com/pytest-dev/pytest/issues/6082>`_: Fix line detection for doctest samples inside ``property`` docstrings, as a workaround to `bpo-17446 <https://bugs.python.org/issue17446>`__. - `6254 <https://github.com/pytest-dev/pytest/issues/6254>`_: Fix compatibility with pytest-parallel (regression in pytest 5.3.0). - `6255 <https://github.com/pytest-dev/pytest/issues/6255>`_: Clear the ``sys.last_traceback``, ``sys.last_type`` and ``sys.last_value`` attributes by deleting them instead of setting them to ``None``. This better matches the behaviour of the Python standard library. ``` ### 5.3.0 ``` ========================= Deprecations ------------ - `6179 <https://github.com/pytest-dev/pytest/issues/6179>`_: The default value of ``junit_family`` option will change to ``xunit2`` in pytest 6.0, given that this is the version supported by default in modern tools that manipulate this type of file. In order to smooth the transition, pytest will issue a warning in case the ``--junitxml`` option is given in the command line but ``junit_family`` is not explicitly configured in ``pytest.ini``. For more information, `see the docs <https://docs.pytest.org/en/latest/deprecations.htmljunit-family-default-value-change-to-xunit2>`__. Features -------- - `4488 <https://github.com/pytest-dev/pytest/issues/4488>`_: The pytest team has created the `pytest-reportlog <https://github.com/pytest-dev/pytest-reportlog>`__ plugin, which provides a new ``--report-log=FILE`` option that writes *report logs* into a file as the test session executes. Each line of the report log contains a self contained JSON object corresponding to a testing event, such as a collection or a test result report. The file is guaranteed to be flushed after writing each line, so systems can read and process events in real-time. The plugin is meant to replace the ``--resultlog`` option, which is deprecated and meant to be removed in a future release. If you use ``--resultlog``, please try out ``pytest-reportlog`` and provide feedback. - `4730 <https://github.com/pytest-dev/pytest/issues/4730>`_: When ``sys.pycache_prefix`` (Python 3.8+) is set, it will be used by pytest to cache test files changed by the assertion rewriting mechanism. This makes it easier to benefit of cached ``.pyc`` files even on file systems without permissions. - `5515 <https://github.com/pytest-dev/pytest/issues/5515>`_: Allow selective auto-indentation of multiline log messages. Adds command line option ``--log-auto-indent``, config option ``log_auto_indent`` and support for per-entry configuration of indentation behavior on calls to ``logging.log()``. Alters the default for auto-indention from ``on`` to ``off``. This restores the older behavior that existed prior to v4.6.0. This reversion to earlier behavior was done because it is better to activate new features that may lead to broken tests explicitly rather than implicitly. - `5914 <https://github.com/pytest-dev/pytest/issues/5914>`_: `testdir <https://docs.pytest.org/en/latest/reference.htmltestdir>`__ learned two new functions, `no_fnmatch_line <https://docs.pytest.org/en/latest/reference.html_pytest.pytester.LineMatcher.no_fnmatch_line>`_ and `no_re_match_line <https://docs.pytest.org/en/latest/reference.html_pytest.pytester.LineMatcher.no_re_match_line>`_. The functions are used to ensure the captured text *does not* match the given pattern. The previous idiom was to use ``re.match``: .. code-block:: python result = testdir.runpytest() assert re.match(pat, result.stdout.str()) is None Or the ``in`` operator: .. code-block:: python result = testdir.runpytest() assert text in result.stdout.str() But the new functions produce best output on failure. - `6057 <https://github.com/pytest-dev/pytest/issues/6057>`_: Added tolerances to complex values when printing ``pytest.approx``. For example, ``repr(pytest.approx(3+4j))`` returns ``(3+4j) ± 5e-06 ∠ ±180°``. This is polar notation indicating a circle around the expected value, with a radius of 5e-06. For ``approx`` comparisons to return ``True``, the actual value should fall within this circle. - `6061 <https://github.com/pytest-dev/pytest/issues/6061>`_: Added the pluginmanager as an argument to ``pytest_addoption`` so that hooks can be invoked when setting up command line options. This is useful for having one plugin communicate things to another plugin, such as default values or which set of command line options to add. Improvements ------------ - `5061 <https://github.com/pytest-dev/pytest/issues/5061>`_: Use multiple colors with terminal summary statistics. - `5630 <https://github.com/pytest-dev/pytest/issues/5630>`_: Quitting from debuggers is now properly handled in ``doctest`` items. - `5924 <https://github.com/pytest-dev/pytest/issues/5924>`_: Improved verbose diff output with sequences. Before: :: E AssertionError: assert ['version', '...version_info'] == ['version', '...version', ...] E Right contains 3 more items, first extra item: ' ' E Full diff: E - ['version', 'version_info', 'sys.version', 'sys.version_info'] E + ['version', E + 'version_info', E + 'sys.version', E + 'sys.version_info', E + ' ', E + 'sys.version', E + 'sys.version_info'] After: :: E AssertionError: assert ['version', '...version_info'] == ['version', '...version', ...] E Right contains 3 more items, first extra item: ' ' E Full diff: E [ E 'version', E 'version_info', E 'sys.version', E 'sys.version_info', E + ' ', E + 'sys.version', E + 'sys.version_info', E ] - `5934 <https://github.com/pytest-dev/pytest/issues/5934>`_: ``repr`` of ``ExceptionInfo`` objects has been improved to honor the ``__repr__`` method of the underlying exception. - `5936 <https://github.com/pytest-dev/pytest/issues/5936>`_: Display untruncated assertion message with ``-vv``. - `5990 <https://github.com/pytest-dev/pytest/issues/5990>`_: Fixed plurality mismatch in test summary (e.g. display "1 error" instead of "1 errors"). - `6008 <https://github.com/pytest-dev/pytest/issues/6008>`_: ``Config.InvocationParams.args`` is now always a ``tuple`` to better convey that it should be immutable and avoid accidental modifications. - `6023 <https://github.com/pytest-dev/pytest/issues/6023>`_: ``pytest.main`` returns a ``pytest.ExitCode`` instance now, except for when custom exit codes are used (where it returns ``int`` then still). - `6026 <https://github.com/pytest-dev/pytest/issues/6026>`_: Align prefixes in output of pytester's ``LineMatcher``. - `6059 <https://github.com/pytest-dev/pytest/issues/6059>`_: Collection errors are reported as errors (and not failures like before) in the terminal's short test summary. - `6069 <https://github.com/pytest-dev/pytest/issues/6069>`_: ``pytester.spawn`` does not skip/xfail tests on FreeBSD anymore unconditionally. - `6097 <https://github.com/pytest-dev/pytest/issues/6097>`_: The "[...%]" indicator in the test summary is now colored according to the final (new) multi-colored line's main color. - `6116 <https://github.com/pytest-dev/pytest/issues/6116>`_: Added ``--co`` as a synonym to ``--collect-only``. - `6148 <https://github.com/pytest-dev/pytest/issues/6148>`_: ``atomicwrites`` is now only used on Windows, fixing a performance regression with assertion rewriting on Unix. - `6152 <https://github.com/pytest-dev/pytest/issues/6152>`_: Now parametrization will use the ``__name__`` attribute of any object for the id, if present. Previously it would only use ``__name__`` for functions and classes. - `6176 <https://github.com/pytest-dev/pytest/issues/6176>`_: Improved failure reporting with pytester's ``Hookrecorder.assertoutcome``. - `6181 <https://github.com/pytest-dev/pytest/issues/6181>`_: The reason for a stopped session, e.g. with ``--maxfail`` / ``-x``, now gets reported in the test summary. - `6206 <https://github.com/pytest-dev/pytest/issues/6206>`_: Improved ``cache.set`` robustness and performance. Bug Fixes --------- - `2049 <https://github.com/pytest-dev/pytest/issues/2049>`_: Fixed ``--setup-plan`` showing inaccurate information about fixture lifetimes. - `2548 <https://github.com/pytest-dev/pytest/issues/2548>`_: Fixed line offset mismatch of skipped tests in terminal summary. - `6039 <https://github.com/pytest-dev/pytest/issues/6039>`_: The ``PytestDoctestRunner`` is now properly invalidated when unconfiguring the doctest plugin. This is important when used with ``pytester``'s ``runpytest_inprocess``. - `6047 <https://github.com/pytest-dev/pytest/issues/6047>`_: BaseExceptions are now handled in ``saferepr``, which includes ``pytest.fail.Exception`` etc. - `6074 <https://github.com/pytest-dev/pytest/issues/6074>`_: pytester: fixed order of arguments in ``rm_rf`` warning when cleaning up temporary directories, and do not emit warnings for errors with ``os.open``. - `6189 <https://github.com/pytest-dev/pytest/issues/6189>`_: Fixed result of ``getmodpath`` method. Trivial/Internal Changes ------------------------ - `4901 <https://github.com/pytest-dev/pytest/issues/4901>`_: ``RunResult`` from ``pytester`` now displays the mnemonic of the ``ret`` attribute when it is a valid ``pytest.ExitCode`` value. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details> Co-authored-by: pyup-bot <github-bot@pyup.io>

aragilar · 2019-12-18T04:37:19Z

This appears to break the testdir fixture, as the fixture assumes that the outcomes will be one of (with no variations) passed, skipped, failed, error, xpassed or xfailed. Can we revert this, as the errors I'm getting are really unhelpful, and make this a pain to debug?

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>

- added a test to check this condition Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>

pytester: quick fix error introduced in #5990

nicoddemus requested changes Oct 18, 2019

View reviewed changes

nicoddemus reviewed Oct 18, 2019

View reviewed changes

MarcoGorelli force-pushed the plurality-matching branch from fa12b2e to 2a568d7 Compare October 18, 2019 15:29

MarcoGorelli changed the base branch from master to features October 18, 2019 15:30

MarcoGorelli force-pushed the plurality-matching branch from 50a36ed to b91db0d Compare October 18, 2019 16:02

blueyed reviewed Oct 18, 2019

View reviewed changes

blueyed changed the title ~~Plurality matching~~ [WIP] Plurality matching Oct 18, 2019

Fix plurality mismatch for and in pytest terminal summary

d863c30

MarcoGorelli force-pushed the plurality-matching branch from b91db0d to d863c30 Compare October 27, 2019 15:16

MarcoGorelli changed the title ~~[WIP] Plurality matching~~ Plurality matching Oct 27, 2019

blueyed approved these changes Oct 28, 2019

View reviewed changes

blueyed requested a review from nicoddemus October 28, 2019 12:47

blueyed merged commit cdc53da into pytest-dev:features Oct 28, 2019

blueyed mentioned this pull request Oct 28, 2019

Plurality mismatch in warnings #5989

Closed

4 tasks

MarcoGorelli deleted the plurality-matching branch October 28, 2019 16:21

aragilar mentioned this pull request Dec 18, 2019

#5990 breaks pytester (by changing "error" to "errors") #6352

Closed

mulatinho added a commit to mulatinho/pytest that referenced this pull request Dec 18, 2019

pytester: quick fix error introduced in pytest-dev#5990

473a55b

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>

mulatinho mentioned this pull request Dec 18, 2019

pytester: quick fix error introduced in #5990 #6353

Merged

mulatinho added a commit to mulatinho/pytest that referenced this pull request Dec 18, 2019

pytester: quick fix error introduced in pytest-dev#5990

dc7bf51

- added a test to check this condition Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>

nicoddemus added a commit that referenced this pull request Dec 27, 2019

pytester: quick fix error introduced in #5990 (#6353)

8077168

pytester: quick fix error introduced in #5990

blueyed mentioned this pull request Dec 30, 2019

Fix RunResult.parseoutcomes (follow-up to #6353) #6382

Merged

Zac-HD mentioned this pull request Jan 19, 2020

5.3 changes plurality of keys in testdir.run().parseoutcomes() #6505

Closed

The-Compiler mentioned this pull request Jul 20, 2020

Check for warnings output during unit tests pytest-dev/pytest-rerunfailures#116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Plurality matching #5990

Plurality matching #5990

MarcoGorelli commented Oct 18, 2019 •

edited by blueyed

The-Compiler commented Oct 18, 2019

MarcoGorelli commented Oct 18, 2019

nicoddemus Oct 18, 2019

MarcoGorelli Oct 18, 2019

The-Compiler Oct 18, 2019

nicoddemus Oct 18, 2019

blueyed Oct 18, 2019

blueyed Oct 18, 2019

MarcoGorelli Oct 18, 2019 •

edited

blueyed Oct 18, 2019

nicoddemus Oct 18, 2019

MarcoGorelli Oct 18, 2019

kalekundert commented Oct 18, 2019

blueyed Oct 18, 2019

MarcoGorelli commented Oct 18, 2019

MarcoGorelli commented Oct 27, 2019

blueyed left a comment

blueyed commented Oct 28, 2019

aragilar commented Dec 18, 2019

		@@ -1007,6 +1007,14 @@ def _folded_skips(skipped):
		return values


		def _match_plurality(count, key):

		@@ -0,0 +1 @@
		Fix plurality mismatch in test summary (e.g. display "2 errors" instead of "2 error").

Plurality matching #5990

Plurality matching #5990

Conversation

MarcoGorelli commented Oct 18, 2019 • edited by blueyed

The-Compiler commented Oct 18, 2019

MarcoGorelli commented Oct 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcoGorelli Oct 18, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kalekundert commented Oct 18, 2019

Choose a reason for hiding this comment

MarcoGorelli commented Oct 18, 2019

MarcoGorelli commented Oct 27, 2019

blueyed left a comment

Choose a reason for hiding this comment

blueyed commented Oct 28, 2019

aragilar commented Dec 18, 2019

MarcoGorelli commented Oct 18, 2019 •

edited by blueyed

MarcoGorelli Oct 18, 2019 •

edited