pytester: quick fix error introduced in #5990 #6353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
Dec 18, 2019
There was a problem hiding this comment.
Thanks a lot @mulatinho!
Please also include a test in testing/test_pytester.py that reproduces the original problem, so we can avoid regressions like this one in the future. 👍
changelog/6532.bugfix.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Fixing error introducted by #5990 | |||
There was a problem hiding this comment.
Suggested change
| Fixing error introducted by #5990 | |
| Fix problem with ``testdir`` not recognizing errors correctly in runs with a single test. |
- added a test to check this condition Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
|
@nicoddemus thanks for the feedback, I added one test to avoid that as you requested. |
nicoddemus
approved these changes
Dec 18, 2019
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Dec 30, 2019
blueyed
added a commit
that referenced
this pull request
Jan 3, 2020
Fix `RunResult.parseoutcomes` (follow-up to #6353)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6352