Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deprecation docs for Node.from_parent #6294

Closed
4 tasks done
nicoddemus opened this issue Nov 30, 2019 · 0 comments · Fixed by #6680
Closed
4 tasks done

Improve deprecation docs for Node.from_parent #6294

nicoddemus opened this issue Nov 30, 2019 · 0 comments · Fixed by #6680
Assignees
@RonnyPfannschmidt
Labels
status: critical grave problem or usability issue that affects lots of users type: deprecation feature that will be removed in the future type: docs documentation improvement, missing or needing clarification
Projects
detangle node structure
Milestone
5.4

Comments

@nicoddemus
Copy link
Member

nicoddemus commented Nov 30, 2019 •
edited by RonnyPfannschmidt

In the "Node Construction changed to Node.from_parent" section in the deprecation docs, we definitely need to add:

  • An example of the warning that users will see (so they can find the session on google).
  • The warning NODE_USE_FROM_PARENT should point to the deprecation docs.
  • Show a "before -> after" example.
  • ensure from_parent will not support config/session
@nicoddemus nicoddemus added type: docs documentation improvement, missing or needing clarification type: deprecation feature that will be removed in the future labels Nov 30, 2019
@nicoddemus nicoddemus added this to the 5.4 milestone Nov 30, 2019
@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Dec 7, 2019
Open
5 tasks
@RonnyPfannschmidt RonnyPfannschmidt added the status: critical grave problem or usability issue that affects lots of users label Jan 15, 2020
@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Feb 7, 2020
Merged
@RonnyPfannschmidt RonnyPfannschmidt moved this from To do to Done in detangle node structure Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RonnyPfannschmidt RonnyPfannschmidt

Labels
status: critical grave problem or usability issue that affects lots of users type: deprecation feature that will be removed in the future type: docs documentation improvement, missing or needing clarification
Projects
detangle node structure
  
Done
Milestone
5.4
Development

Successfully merging a pull request may close this issue.

doc: more docs for from_parent RonnyPfannschmidt/pytest
2 participants
@RonnyPfannschmidt @nicoddemus