Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tighten Node.parent to Collector and resolve the resulting typing issues #8244

Open
RonnyPfannschmidt opened this issue Jan 16, 2021 · 0 comments
Open

tighten Node.parent to Collector and resolve the resulting typing issues #8244

RonnyPfannschmidt opened this issue Jan 16, 2021 · 0 comments
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: refactoring internal improvements to the code

Comments

@RonnyPfannschmidt
Copy link
Member

Can this be Collector? (Although would be a typing breaking change for from_parent...)

Originally posted by @bluetech in #8037 (comment)
@RonnyPfannschmidt RonnyPfannschmidt added type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: refactoring internal improvements to the code labels Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: refactoring internal improvements to the code
Projects
detangle node structure
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RonnyPfannschmidt