Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #10178

Merged
merged 5 commits into from
Aug 22, 2022
Merged

Conversation

setup.cfg Outdated
@@ -17,10 +17,6 @@ classifiers =
Operating System :: POSIX
Programming Language :: Python :: 3
Programming Language :: Python :: 3 :: Only
Programming Language :: Python :: 3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was formatted by setup-cfg-fmt... not sure if this is expected or a bug?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this was an intentional change in 2.0.0 -- if you want these back there's an option --include-version-classifiers -- but I'm removing them from all of my projects since they're (1) noisy (2) invite spammy PRs (3) are redundant to python_requires and (4) make it more manual work to drop old python versions -- I have no opinions on what pytest chooses though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're probably useless and redundant, but at this point who knows what's using them, so I say keep them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added --include-version-classifiers to setup-cfg-fmt then.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 6b5e548 to 1a97fcf Compare August 8, 2022 23:03
updates:
- [github.com/PyCQA/flake8: 4.0.1 → 5.0.4](PyCQA/flake8@4.0.1...5.0.4)
- [github.com/asottile/pyupgrade: v2.37.2 → v2.37.3](asottile/pyupgrade@v2.37.2...v2.37.3)
- [github.com/asottile/setup-cfg-fmt: v1.20.2 → v2.0.0](asottile/setup-cfg-fmt@v1.20.2...v2.0.0)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from f683a69 to 59a09e3 Compare August 22, 2022 22:27
@nicoddemus nicoddemus enabled auto-merge (squash) August 22, 2022 23:07
@nicoddemus nicoddemus merged commit 42776c0 into main Aug 22, 2022
@nicoddemus nicoddemus deleted the pre-commit-ci-update-config branch August 22, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants