Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 7.2.0 #10412

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Prepare release 7.2.0 #10412

merged 1 commit into from
Oct 25, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Created automatically from manual trigger.

Once all builds pass and it has been approved by one or more maintainers, the build
can be released by pushing a tag 7.2.0 to this repository.

@@ -1963,7 +1960,7 @@ All the command-line flags can be obtained by running ``pytest --help``::
Default marker for empty parametersets
norecursedirs (args): Directory patterns to avoid for recursion
testpaths (args): Directories to search for tests when no files or
directories are given in the command line
directories are given on the command line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this looks like we might have had some typo fixes in places where its not helpfull

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean, is there a problem with those changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i think i missread the diff
we might want to make regendoc a regular check for the branches to open regendoc fixup prs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... in fact, we could make an action that runs anytime a PR is opened or pushed to: it would run regendoc, and push a new commit if any .rst files have changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that unfortunately can't be done safely without exposing privileged credentials to the pull request code or using a third party app to do the pushing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile would it be safe enough safe, i we would have to trigger an actual workflow action on main with the pr as parameter (similar to the create pr workflow)

that way the pr code would work similar to the workflow for creating a release

another alternative would be to just always have a release pr on standby (instead of manually triggering them) and using them as indicator

@nicoddemus nicoddemus closed this Oct 23, 2022
@nicoddemus nicoddemus reopened this Oct 23, 2022
@RonnyPfannschmidt
Copy link
Member

@nicoddemus for practical reasons i'll defer pulling the trigger to when i get into office tommorow morning

@nicoddemus
Copy link
Member

Sure thing. 👍

Thanks for taking care of this release.

Comment on lines +72 to +73
- `#10218 <https://github.com/pytest-dev/pytest/issues/10218>`_: ``@pytest.mark.parametrize()`` (and similar functions) now accepts any ``Sequence[str]`` for the argument names,
instead of just ``list[str]`` and ``tuple[str, ...]``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem to go to the right place

@RonnyPfannschmidt
Copy link
Member

gone with a signed tag will merge after release

@RonnyPfannschmidt RonnyPfannschmidt merged commit ac4e3cc into 7.2.x Oct 25, 2022
@RonnyPfannschmidt RonnyPfannschmidt deleted the release-7.2.0 branch October 25, 2022 08:58
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this pull request Oct 25, 2022
Prepare release 7.2.0

(cherry picked from commit ac4e3cc)
The-Compiler pushed a commit that referenced this pull request Oct 25, 2022
Prepare release 7.2.0

(cherry picked from commit ac4e3cc)
@nicoddemus
Copy link
Member

Was 7.2.0 announced on Twitter?

@The-Compiler
Copy link
Member

Was 7.2.0 announced on Twitter?

Looks like it was in the meantime! (retweeted by @pytestdotorg too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants