-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flake8-pytest-style to plugin_list.rst #10939
add flake8-pytest-style to plugin_list.rst #10939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is autogenerated, unless you we add a extra condition to the script that creates it, the weekly update will just drop it out again
i recommend waiting a little with the script as i'm about to fixup and merge #10927 |
To me, this seems like the wrong place entirely for this anyways - after all, this is not a pytest plugin, it's a plugin for the flake8 linter. As I suggested in #10709 already, I think the Good Practices page in the docs would be the perfect place for this. |
So should I remove it from |
That's what I would recommend, yep! |
Added mention about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sergkim13, I think this can help users better use pytest.
However, since this appears in the official "good practices" doc, I think it's necessary to add a note like this:
Disclaimer: flake8-pytest-style is not an official pytest project.
cc @m-burst, author of flake8-pytest-style, if you have any comments let us know! |
@bluetech, done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sergkim13. I hope your first open source contribution went well and won't be your last :)
I want to add my 2 cents as the author of |
@m-burst @sergkim13 What do you think about the following? flake8-pytest-style is not an official pytest project. Some of the rules enforce certain style choices, such as using |
Hello! This is my first PR in opensource project. Please, don't judge me harshly.
This PR closes #10709 by adding
flake8-pytest-style
toplugin_list.rst
.